New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCAL] make makeHGCalValidationPlots.py executable again #34909
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34909/24717
|
A new Pull Request was created by @apsallid for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
If this only changes the permissions of a script, it can be probably merged as such, even without testing... |
@perrotta it's evident from just seeing the file in files: |
Thank you @mrodozov |
@perrotta , it shows the permission there e.g.
so looks good. |
Uhm, I'm learning. Therefore, the key is
Cool, I didn't know... |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-298d2e/17840/summary.html Comparison SummarySummary:
|
PR description:
PR #34702 accidentally changed the permissions on
makeHGCalValidationPlots.py
, so the commandmakeHGCalValidationPlots.py
doesn't work. This PR should correct this mistake and makemakeHGCalValidationPlots.py
executable again.PR validation:
I have tested locally that the command works now as usual.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is not a backport.
@rovere @felicepantaleo @ebrondol @lecriste @mrodozov @waredjeb