Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL] make makeHGCalValidationPlots.py executable again #34909

Merged
merged 1 commit into from Aug 17, 2021

Conversation

apsallid
Copy link
Contributor

PR description:

PR #34702 accidentally changed the permissions on makeHGCalValidationPlots.py, so the command makeHGCalValidationPlots.py doesn't work. This PR should correct this mistake and make makeHGCalValidationPlots.py executable again.

PR validation:

I have tested locally that the command works now as usual.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport.

@rovere @felicepantaleo @ebrondol @lecriste @mrodozov @waredjeb

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34909/24717

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apsallid for master.

It involves the following packages:

  • Validation/HGCalValidation (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @bsunanda, @pfs, @lecriste, @hatakeyamak, @ebrondol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

If this only changes the permissions of a script, it can be probably merged as such, even without testing...
One should just certify that the permissions were actually modified as wanted

@mrodozov
Copy link
Contributor

@perrotta it's evident from just seeing the file in files:
https://github.com/cms-sw/cmssw/pull/34909/files

@perrotta
Copy link
Contributor

@perrotta it's evident from just seeing the file in files:
https://github.com/cms-sw/cmssw/pull/34909/files

Thank you @mrodozov
How can I verify which are the permissions from there? I would have naively imported this PR in an IB locally and looked at the permissions there... But if it can be done faster it's even better!

@smuzaffar
Copy link
Contributor

@perrotta , it shows the permission there e.g.

 Validation/HGCalValidation/scripts/makeHGCalValidationPlots.py  100644 → 100755

so looks good.

@perrotta
Copy link
Contributor

Uhm, I'm learning.

Therefore, the key is

  • 100644 means -rw-r--r-- where:
4 == r--
4 == r--
6 == rw-
100 == -
  • 100755 means -rwxr-xr-x where:
5 == r-x
5 == r-x
7 == rwx
100 == -

Cool, I didn't know...

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5e1bfed into cms-sw:master Aug 17, 2021
@jfernan2
Copy link
Contributor

+1
for the records

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-298d2e/17840/summary.html
COMMIT: 0839674
CMSSW: CMSSW_12_1_X_2021-08-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34909/17840/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000352
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3000312
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants