Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.3.X] do not produce NaNs in SiPixelActionExecutor #34937

Merged
merged 1 commit into from Aug 20, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 18, 2021

backport of #34900

PR description:

Title says is all, related to issue #34890

PR validation:

Run wf 8.0 with runTheMatrix.py -l 8.0 -j 8 and inspected output DQM ROOT file.

averageDigiOccupancy avgfedDigiOccvsLumi
image image

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #34900

@mmusich
Copy link
Contributor Author

mmusich commented Aug 18, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_3_X.

It involves the following packages:

  • DQM/SiPixelMonitorClient (dqm)
  • DQM/SiPixelMonitorDigi (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Aug 18, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd3348/17866/summary.html
COMMIT: 9e7a815
CMSSW: CMSSW_11_3_X_2021-08-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34937/17866/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2878314
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2878291
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 20, 2021

+1

@cmsbuild cmsbuild merged commit 7a50edf into cms-sw:CMSSW_11_3_X Aug 20, 2021
@mmusich mmusich deleted the fixWf8.0comparisons_11_3_X branch August 20, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants