Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.3.X] migrate AlignmentProducer to event consumes #34946

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 19, 2021

backport of #34885

PR description:

Title says it all, migrate AlignmentProducer to event consumes, as it is already done for AlignmentProducerAsAnalyzer.cc

tjTkAssociationMapToken_ = consumes<TrajTrackAssociationCollection>(tjTkAssociationMapTag_);
beamSpotToken_ = consumes<reco::BeamSpot>(beamSpotTag_);
tkLasBeamToken_ = consumes<TkFittedLasBeamCollection>(tkLasBeamTag_);
tsosVectorToken_ = consumes<TsosVectorCollection>(tkLasBeamTag_);
clusterValueMapToken_ = consumes<AliClusterValueMap>(clusterValueMapTag_);

PR validation:

Run unit tests scram b runtests also using Alignment/TrackerAlignment package.

if this PR is a backport please specify the original PR and why you need to backport that PR:

11.3.X backport of PR #34885

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_3_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 19, 2021

type bug-fix

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07aa00/17883/summary.html
COMMIT: d7ec6bb
CMSSW: CMSSW_11_3_X_2021-08-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34946/17883/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2878314
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2878279
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 19, 2021

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 20, 2021

+1

@cmsbuild cmsbuild merged commit 07247b0 into cms-sw:CMSSW_11_3_X Aug 20, 2021
@mmusich mmusich deleted the Alignment/CommonAlignmentProducer_migrateToConsumes_11_3_X branch August 20, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants