Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uploading the EventSetup conditions to multiple CUDA devices [12.0.x] #34949

Merged
merged 3 commits into from Aug 23, 2021
Merged

Fix uploading the EventSetup conditions to multiple CUDA devices [12.0.x] #34949

merged 3 commits into from Aug 23, 2021

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 19, 2021

PR description:

When multiple CUDA devices are available, each CUDA EventSetup object uses a different CUDA event to keep track if the conditions have been uploaded to each device. However, all events were associated to the default device, instead of the correct one, leading to a runtime error when multiple devices were used.

These changes associate to the correct CUDA device the events used to track if the conditions have been transferred.

PR validation:

See #34948 .

If this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #34948 .

@fwyzard
Extend the cms::cuda::ScopedSetDevice interface
1d940d4 
Add a default constructor that stores the current devices, without
changing it.

Add a set() method to change the current device, without affecting the
stored value for the original device.
@fwyzard
Fix uploading the EventSetup conditions to multiple CUDA devices
097fe4a 
Associate to the correct CUDA device the events used to track if the
conditions have been transferred to each device.
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 19, 2021

type bugfix

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Aug 19, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2021 •
edited

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_0_X.

It involves the following packages:

  • HeterogeneousCore/CUDACore (heterogeneous)
  • HeterogeneousCore/CUDAUtilities (heterogeneous)

@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 19, 2021

backport #34948

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 19, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22bdcb/17886/summary.html
COMMIT: 097fe4a
CMSSW: CMSSW_12_0_X_2021-08-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34949/17886/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998541
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 19, 2021

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 22, 2021

Done, thanks.

@cmsbuild
Copy link
Contributor

Pull request #34949 was updated. @makortel, @cmsbuild, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 22, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22bdcb/17949/summary.html
COMMIT: c9c01df
CMSSW: CMSSW_12_0_X_2021-08-22-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34949/17949/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998530
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Aug 23, 2021
@makortel
Copy link
Contributor

@cmsbuild, please test workflow 136.885501

Just to make sure

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22bdcb/17953/summary.html
COMMIT: c9c01df
CMSSW: CMSSW_12_0_X_2021-08-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34949/17953/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-22bdcb/136.885501_RunHLTPhy2018D+RunHLTPhy2018D+HLTDR2_2018+RECODR2_2018reHLT_Patatrack_PixelOnlyCPU+HARVEST2018_pixelTrackingOnly

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 557a7e8 into cms-sw:CMSSW_12_0_X Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok bug-fix fully-signed heterogeneous-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @makortel @perrotta