[GCC11] Fix warnings: loop variable binds to a temporary #35044

iarspider · 2021-08-27T12:52:10Z

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-24-0900/JetMETCorrections/Modules

 .../JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc:115:23: warning: loop variable 'binVariable' of type 'const TString&' binds to a temporary constructed from type 'const char* const' [-Wrange-loop-construct]
   115 |   for (const TString& binVariable : {"eta", "pt", "rho"}) {
      |                       ^~~~~~~~~~~
.../JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc:115:23: note: use non-reference type 'const TString' to make the copy explicit or 'const char* const&' to prevent copying
 .../JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc:127:23: warning: loop variable 'type' of type 'const TString&' binds to a temporary constructed from type 'const char* const' [-Wrange-loop-construct]
   127 |   for (const TString& type : {"gluon", "quark"}) {
      |                       ^~~~
.../JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc:127:23: note: use non-reference type 'const TString' to make the copy explicit or 'const char* const&' to prevent copying
 .../JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc:129:25: warning: loop variable 'likelihoodVar' of type 'const TString&' binds to a temporary constructed from type 'const char* const' [-Wrange-loop-construct]
   129 |     for (const TString& likelihoodVar : {"mult", "ptD", "axis2"}) {
      |                         ^~~~~~~~~~~~~

JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc

cmsbuild · 2021-08-27T13:08:49Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24907

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24907/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24907/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-08-27T13:36:01Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24908

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24908/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24908/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-08-27T13:49:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24909

This PR adds an extra 16KB to repository

cmsbuild · 2021-08-27T13:49:37Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

JetMETCorrections/Modules (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc

cmsbuild · 2021-08-27T14:17:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24914

This PR adds an extra 20KB to repository

cmsbuild · 2021-08-27T14:17:24Z

Pull request #35044 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

iarspider · 2021-08-27T14:17:49Z

please test for slc7_amd64_gcc11

cmsbuild · 2021-08-27T18:42:35Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18089/summary.html
COMMIT: 1369d30
CMSSW: CMSSW_12_1_X_2021-08-25-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35044/18089/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18089/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18089/git-merge-result

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18089/llvm-analysis/legacy-mod-sa.txt for details.
Found compilation warnings

Unit Tests

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

RelVals

135.4

----- Begin Fatal Exception 27-Aug-2021 19:47:32 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

5.1

----- Begin Fatal Exception 27-Aug-2021 19:47:32 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

AddOn Tests

fastsim

----- Begin Fatal Exception 27-Aug-2021 19:49:40 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 27-Aug-2021 19:49:40 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 27-Aug-2021 19:49:41 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

slava77 · 2021-08-27T19:00:23Z

Failed Tests: UnitTests RelVals AddOn

I guess this is acceptable considering that the test was for slc7_amd64_gcc11, which has some other build problems

slava77 · 2021-08-27T19:01:11Z

@cmsbuild please test

to check the regular build

cmsbuild · 2021-08-27T22:14:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18103/summary.html
COMMIT: 1369d30
CMSSW: CMSSW_12_1_X_2021-08-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35044/18103/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18103/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000330
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

slava77 · 2021-08-27T23:32:21Z

+reconstruction

for #35044 1369d30

code changes are technical, in line with the PR description and the follow up review. Note, the modified producer code QGLikelihoodDBWriter.cc is not a part of the standard test workflows.
jenkins tests pass

cmsbuild · 2021-08-27T23:32:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-08-28T06:27:37Z

+1

Similar updates as implemented for other previous fixes of that kind

[GCC11] Fix warnings: loop variable binds to a temporary

e72505f

cmsbuild added this to the CMSSW_12_1_X milestone Aug 27, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 27, 2021

slava77 reviewed Aug 27, 2021

View reviewed changes

JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc Outdated Show resolved Hide resolved

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 27, 2021

code-format

88de6ce

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 27, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 27, 2021

code-format #2

64de4e1

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 27, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 27, 2021

slava77 reviewed Aug 27, 2021

View reviewed changes

JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc Outdated Show resolved Hide resolved

Update QGLikelihoodDBWriter.cc

1f32551

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 27, 2021

iarspider added 2 commits August 27, 2021 15:57

Update QGLikelihoodDBWriter.cc

fdd8eb1

Update QGLikelihoodDBWriter.cc

68e3ea7

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 27, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 27, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 27, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 27, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 27, 2021

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Aug 27, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 28, 2021

cmsbuild merged commit aa4de07 into cms-sw:master Aug 28, 2021

iarspider deleted the patch-4 branch August 28, 2021 17:44

This was referenced Aug 30, 2021

Updated root to tip of branch v6-24-00-patches cms-sw/cmsdist#7251

Merged

fix undefined behavior in MultiTrackValidator #35086

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GCC11] Fix warnings: loop variable binds to a temporary #35044

[GCC11] Fix warnings: loop variable binds to a temporary #35044

iarspider commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

iarspider commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

slava77 commented Aug 27, 2021

slava77 commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

slava77 commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

perrotta commented Aug 28, 2021

[GCC11] Fix warnings: loop variable binds to a temporary #35044

[GCC11] Fix warnings: loop variable binds to a temporary #35044

Conversation

iarspider commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

iarspider commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

Unit Tests

RelVals

AddOn Tests

slava77 commented Aug 27, 2021

slava77 commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

Comparison Summary

slava77 commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

perrotta commented Aug 28, 2021