New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCC11] Fix warnings: loop variable binds to a temporary #35044
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24907
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24908
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24909
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35044/24914
|
please test for slc7_amd64_gcc11 |
-1 Failed Tests: UnitTests RelVals AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18089/llvm-analysis/legacy-mod-sa.txt for details. Unit TestsI found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS RelVals
AddOn Tests
|
I guess this is acceptable considering that the test was for slc7_amd64_gcc11, which has some other build problems |
@cmsbuild please test to check the regular build |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18103/summary.html CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41cd/18103/llvm-analysis/legacy-mod-sa.txt for details. Comparison SummarySummary:
|
+reconstruction for #35044 1369d30
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-24-0900/JetMETCorrections/Modules