Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digi to the modified steps for bParking workflows #35061

Merged
merged 1 commit into from Aug 30, 2021

Conversation

elusian
Copy link

@elusian elusian commented Aug 28, 2021

PR description:

#33996 added new collections to the RAWSIM, AODSIM and MINIAODSIM eventcontents, gated behind the bParking modifier.
However, some bParking workflows (10824.8) run step2 without the bParking modifier, which causes a ProductNotFound exception in step3.
This PR modifies PyReleaseValidation to add the bParking modifier in step2 for bParking workflows created in relval_upgrade.py

PR validation:

Tested on the previously failing 10824.8 workflow. Also compared the output of runTheMatrix.py -n --ext before and after the change and verified that the only modified workflow is 10824.8

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, as agreed in #33996 (comment)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @elusian for CMSSW_10_6_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

test parameters:

  • workflow = 10824.8

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-739fc0/18117/summary.html
COMMIT: 0469547
CMSSW: CMSSW_10_6_X_2021-08-27-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35061/18117/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Aug 30, 2021

type bugfix

@qliphy
Copy link
Contributor

qliphy commented Aug 30, 2021

urgent
(Would be good to include in next 10_6_X to be made this week)

@srimanob
Copy link
Contributor

+Upgrade

This technical PR is to add barking era to the digi step of the 10_6 release. There is no need for the master because RAW in master already include what needs for, result from #33774

@jordan-martins
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 30, 2021

+1

@cmsbuild cmsbuild merged commit 18f3f68 into cms-sw:CMSSW_10_6_X Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants