Migrate CondTools-Ecal modules to use esconsumes

[sroychow]

PR description:

Part of #31061. Migrates modules of CondTools/Ecal to use esConsumes.

PR validation:

Code compiles and scram checker doesn't show the EventSetup get warnings.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35079/24960

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

• CondTools/Ecal (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @mmusich, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[sroychow]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1623a0/18147/summary.html
COMMIT: 2c748c8
CMSSW: CMSSW_12_1_X_2021-08-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35079/18147/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 3 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1623a0/18147/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000376
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Migration in the package is not complete yet: still missing CondTools/Ecal/src/ESDBCopy.cc

Please also have a look at the static analyzer, which points out a large number of dead initializations or assignments. That should also get eventually fixed, (not necessarily in this PR) as those dead assignments may hide/witness possible real issues in the logic of the code.

[thomreis]

Migration in the package is not complete yet: still missing CondTools/Ecal/src/ESDBCopy.cc

This is done in #35149 .

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35079/25217

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35079 was updated. @ggovi, @cmsbuild can you please check and sign again.

[sroychow]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1623a0/18535/summary.html
COMMIT: 58ad57e
CMSSW: CMSSW_12_1_X_2021-09-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35079/18535/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2995 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 7709
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2993270
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 1 / 38 workflows

[tvami]

+db

• Giacomo already signed a previous version

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1