Adding protections to PATTriggerProducer when the path has zero filters: 12_0

[Sam-Harper]

PR description:

This is the back port of #35043 which is a bug fix to prevent a seg fault in a particular way of running pat trigger producer on a particularly produced sample.

It would be great if this was backported to 12_0 as it users may well be using it there as well.

PR validation:

validated as part of #35043

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_12_0_X.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @JyothsnaKomaragiri, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @mbluj, @gpetruc, @andrzejnovak, @demuller, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Adding protections to PATTriggerProducer when the path has zero filters: 12_1 #35043

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c64797/18192/summary.html
COMMIT: 43d0871
CMSSW: CMSSW_12_0_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35087/18192/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998536
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[perrotta]

backport of #35043

[slava77]

+reconstruction

for #35087 43d0871

• code changes are the same (the same topic branch) as in the master PR Adding protections to PATTriggerProducer when the path has zero filters: 12_1 #35043, which was merged 5 days ago; the backport is a somewhat technical for most workflows and a bugfix for a special case
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1