Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for PAT python configuration files #3510

Conversation

ferencek
Copy link
Contributor

This PR is the second part of the closed #3408 after factorization. It primarily addresses some of the problems reported in https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3137.html

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_1_X.

Updates for PAT python configuration files

It involves the following packages:

PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Apr 27, 2014

@ferencek Wouldn't it be better to make JME default so that endusers do not need to change naming in their configuration file? Then we need to add the option to check closest Z vertex for pfNoPileUpIso.

@ferencek
Copy link
Contributor Author

@monttj That is not my call. I simply fixed the module names as defined in https://github.com/cms-sw/cmssw/tree/CMSSW_7_1_X/CommonTools/ParticleFlow/python Note that there are now 3 pfNoPileUp sequences defined (pfNoPileUp, pfNoPileUpIso, and pfNoPileUpJME)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Apr 28, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 28, 2014
…rom-CMSSW_7_1_X_2014-04-25-1400

AT -- Updates for PAT python configuration files
@ktf ktf merged commit d5a1ca6 into cms-sw:CMSSW_7_1_X Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants