[GCC11] Fix compilation warning for CommonTools

[smuzaffar]

This should fix the GCC11 IB warnings

 CommonTools/Utils/test/testDynArray.cpp:54:3: warning: '*q_storage.2_54 + _82' may be used uninitialized [-Wmaybe-uninitialized]
    54 |   if (q[n - 1])
      |   ^~

I think compiler thinks that n could be 0 if s<=0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35144/25061

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• CommonTools/Utils (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

please test for slc7_amd64_gcc11

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-600b79/18289/summary.html
COMMIT: 72eb238
CMSSW: CMSSW_12_1_X_2021-09-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18289/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000382
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-600b79/18297/summary.html
COMMIT: 72eb238
CMSSW: CMSSW_12_1_X_2021-09-01-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @abdoulline [UBSAN] DataFormats/CaloTowers initialization fix #35068
• @swagata87 [EGM HLT] Phase out calotower & use HCAL recHits directly #35049
• @dildick Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779
• @dinyar Correct RegionalMuon (un)packer when running on EMTF data #34801
• @guitargeek Merge .h and .cc files of plugins in several PhysicsTools packages #34615
• @TaeunKwon HCAL: fixing pulse containment correction algorithm for Run3 trigger primitives #34805
• @makortel Migrate BMixingModule and EcalShapeBase-derived classes to esConsumes #34902
• @stahlleiton Adapt CAConstants for HIon #35017
• @srimanob Adding fake alignment to make tracker geometry test work #35119
• @smuzaffar [GCC11] Ignore used uninitialized warning in DTDigiSimLink #35114
• @smuzaffar [GCC11] Fix compiler warnings for RecoPPS #35113
• @smuzaffar [GCC11] Fix comopiler warnings for LumiProducer #35112
• @smuzaffar [GCC11] Fix warnings for EgammaHLTProducers #35110
• @Dr15Jones Removed undefined use of union in libminifloat #35054
• @bsunanda Run3-hcx314 Reorganize the files in SimCalorimetry/CastorTechTrigProducer and merge .h files #35093
• @Dr15Jones Modernized JetTagProducer #35078
• @ggovi Delete unused headers/test files (DB packages) #34933
• @smuzaffar Remove duplicate include statements #35122
• @Dr15Jones Enable services in concurrent endJob processing #35120
• @srimanob disable 136.72413 in relval_standard #35121
• @jeongeun Migrate module configuration in PhysicsTools{PatUtils} to use default cfipython #35101
• @perrotta Get rid of the unneeded conf_ class member in SiPixelPhase1EfficiencyExtras #35102
• @smuzaffar [L1Trigger] Move public headers in to interface directory #34895
• @Dr15Jones Modernize some EGamma Reco modules #35021

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-600b79/18297/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-600b79/18297/git-merge-result

Found compilation warnings

Unit Tests

I found errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

RelVals

• 312.0

----- Begin Fatal Exception 03-Sep-2021 20:25:51 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO
----- End Fatal Exception -------------------------------------------------

• 11634.0

----- Begin Fatal Exception 03-Sep-2021 20:36:26 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

• 11634.912

----- Begin Fatal Exception 03-Sep-2021 20:37:46 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/11634.912_TTbar_14TeV+2021_DD4hepDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 12434.0
• 11634.911
• 23234.0
• 34634.0
• 28234.0
• 34834.999

AddOn Tests

• hlt_mc_GRun

----- Begin Fatal Exception 03-Sep-2021 20:22:28 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------

• hlt_mc_HIon

----- Begin Fatal Exception 03-Sep-2021 20:22:43 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_HIon
----- End Fatal Exception -------------------------------------------------

• hlt_mc_PIon

----- Begin Fatal Exception 03-Sep-2021 20:22:42 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Running EventSetup component CSCL1TPLookupTableEP/'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/BendingAngle/GEMCSCLUT_es_diff_slope_L1_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35144/18297/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-09-01-1100/external/slc7_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_PIon
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

• hlt_mc_PRef

[slava77]

+reconstruction

for #35144 72eb238

• code changes are technical in line with the PR description and the follow up review; these affect only CommonTools/Utils/test/testDynArray.cpp
• jenkins tests pass and comparisons with the baseline show no differences in the gcc10 build and there are no warnings in the slc7_amd64_gcc11 compilation log around testDynArray.cpp

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1