Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the radiation map to be used with GeometryExtended2026D86Reco #35165

Merged
merged 2 commits into from Sep 8, 2021

Conversation

pfs
Copy link
Contributor

@pfs pfs commented Sep 6, 2021

PR description:

This PR updates the radiation map to be used with the 47-layer geometry of HGCAL, following the latest Fluka simulations by BRIL.
The plotting validation tool under SimCalorimetry/HGCalSimAlgos is also updated.

PR validation:

The radiation maps (fluence and dose) for D49 (50-layer) and D86 (47-layer) have been inspected and found to be compatible with the expectations from Fluka.
A summary can be found in the following PDF

RadiationMapHGCAL.pdf

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35165/25094

  • This PR adds an extra 20KB to repository

  • Found files with invalid states:

    • Traceback (most recent call last):
      • File "/afs/cern.ch/user/c/cmsbuild/public/jenkins/cms-bot/process-pull-request", line 37, in
        • for c in pr.get_commits():
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/PaginatedList.py", line 49, in iter
        • newElements = self._grow()
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/PaginatedList.py", line 61, in _grow
        • newElements = self._fetchNextPage()
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/PaginatedList.py", line 162, in _fetchNextPage
        • headers=self.__headers
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Requester.py", line 172, in requestJsonAndCheck
        • return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Requester.py", line 213, in requestJson
        • return self.__requestEncode(cnx, verb, url, parameters, headers, input, encode)
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Requester.py", line 252, in __requestEncode
        • status, responseHeaders, output = self.__requestRaw(cnx, verb, url, requestHeaders, encoded_input)
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Requester.py", line 277, in __requestRaw
        • requestHeaders
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/external/python/2.7.15-cms/lib/python2.7/httplib.py", line 1042, in request
        • self._send_request(method, url, body, headers)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/external/python/2.7.15-cms/lib/python2.7/httplib.py", line 1082, in _send_request
        • self.endheaders(body)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/external/python/2.7.15-cms/lib/python2.7/httplib.py", line 1038, in endheaders
        • self._send_output(message_body)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/external/python/2.7.15-cms/lib/python2.7/httplib.py", line 882, in _send_output
        • self.send(msg)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/external/python/2.7.15-cms/lib/python2.7/httplib.py", line 844, in send
        • self.connect()
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/external/python/2.7.15-cms/lib/python2.7/httplib.py", line 1255, in connect
        • HTTPConnection.connect(self)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/external/python/2.7.15-cms/lib/python2.7/httplib.py", line 821, in connect
        • self.timeout, self.source_address)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/external/python/2.7.15-cms/lib/python2.7/socket.py", line 575, in create_connection
        • raise err
    • socket.timeout: timed out

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35165/25101

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2021

A new Pull Request was created by @pfs (Pedro Silva) for master.

It involves the following packages:

  • SimCalorimetry/HGCalSimAlgos (upgrade, simulation)
  • SimCalorimetry/HGCalSimProducers (upgrade, simulation)

@cmsbuild, @AdrianoDee, @civanch, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

srimanob commented Sep 7, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4d809/18352/summary.html
COMMIT: 9f84df0
CMSSW: CMSSW_12_1_X_2021-09-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35165/18352/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000979
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Sep 7, 2021

+1

@srimanob
Copy link
Contributor

srimanob commented Sep 7, 2021

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 8, 2021

+1

@cmsbuild cmsbuild merged commit a0f23a3 into cms-sw:master Sep 8, 2021
@pfs pfs deleted the radmap_update branch November 18, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants