Thread safety cleanup in SiStripRecHitMatcher

[wddgit]

Modify return type of SiStripRecHitMatcher::match
from a bare pointer to a unique_ptr. This eliminates
a report from the thread safety static code checker
of a potential thread safety problem. Also modify the
one file where this function is called to use
the new interface.

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X.

Thread safety cleanup in SiStripRecHitMatcher

It involves the following packages:

RecoLocalTracker/SiStripRecHitConverter
RecoTracker/TransientTrackingRecHit

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

+1

for #3517 6b41522

tested in CMSSW_7_1_X_2014-04-26-1000
(test area sign359 in a combination of pulls 3503 3512 3513 3514 3515 3517)
no differences in reco outputs based on the short matrix test (15 workflows)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3517/1094/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?