Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-trk08X Provides namespace to all created solids/volumes (backport #35065) #35170

Merged
merged 1 commit into from Sep 7, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Sep 6, 2021

PR description:

Provides namespace to all created solids/volumes (backport #35065)

PR validation:

Tested using to the runTheMatrix test workflows in #35065

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backporting #35065

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Sep 6, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2021

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_0_X.

It involves the following packages:

  • Geometry/TrackerCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @JanFSchulte, @VinInn, @mmusich, @ghugo83, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 6, 2021

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-294b2a/18340/summary.html
COMMIT: 319d80e
CMSSW: CMSSW_12_0_X_2021-09-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35170/18340/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 7, 2021

Note that this PR affects only DD4hep, not DDD.

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2021

+1

@cmsbuild cmsbuild merged commit a37f5ff into cms-sw:CMSSW_12_0_X Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants