ECAL esConsumes migration for remaining SimCalorimetry occurrences

[thomreis]

PR description:

The PR migrates remaining ECAL related code in the SimCalorimetry packages to esConsumes (#31061). The constructor of EcalSignalGenerator was changed to accept a ConsumesCollector that is now also used to get the token for the input data collection.

PR validation:

Code compiles. Passes 25202.0.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35176/25108

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

• SimCalorimetry/EcalElectronicsEmulation (simulation)
• SimCalorimetry/EcalSelectiveReadoutProducers (simulation)
• SimCalorimetry/EcalSimAlgos (simulation)
• SimCalorimetry/EcalSimProducers (simulation)
• SimCalorimetry/EcalZeroSuppressionProducers (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @rovere, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8224d4/18383/summary.html
COMMIT: 506797a
CMSSW: CMSSW_12_1_X_2021-09-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35176/18383/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1