Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSSW_12_0_X] Add new Run3 offline GT in autoCond and its relval workflow #35231

Merged
merged 2 commits into from Sep 13, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Sep 10, 2021

PR description:

Backport of #35202

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 10, 2021

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Sep 10, 2021

backport of #35202

@tvami
Copy link
Contributor Author

tvami commented Sep 10, 2021

test parameters:

  • workflows = 138.1,136.897

@tvami
Copy link
Contributor Author

tvami commented Sep 10, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5b48c/18502/summary.html
COMMIT: 5467a22
CMSSW: CMSSW_12_0_X_2021-09-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35231/18502/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

RelVals-INPUT

@tvami
Copy link
Contributor Author

tvami commented Sep 10, 2021

@smuzaffar will this new RelVal input buffering, that you mentioned in #35202 (comment) , have to happen separately for each branch?

@tvami
Copy link
Contributor Author

tvami commented Sep 11, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5b48c/18508/summary.html
COMMIT: 5467a22
CMSSW: CMSSW_12_0_X_2021-09-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35231/18508/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

RelVals-INPUT

@qliphy
Copy link
Contributor

qliphy commented Sep 11, 2021

@tvami

From https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5b48c/18508/dasqueries/run.txt
I see "KeyError: 'RunCosmics2021'"

It seems you should also backport #34643

@cmsbuild
Copy link
Contributor

Pull request #35231 was updated. @malbouis, @yuanchao, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @francescobrivio, @tvami can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Sep 11, 2021

@tvami

From https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5b48c/18508/dasqueries/run.txt
I see "KeyError: 'RunCosmics2021'"

It seems you should also backport #34643

Thanks!

@tvami
Copy link
Contributor Author

tvami commented Sep 11, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5b48c/18523/summary.html
COMMIT: 2d63a98
CMSSW: CMSSW_12_0_X_2021-09-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35231/18523/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a5b48c/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a5b48c/138.1_RunCosmics2021+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

PRs run fine with the new 2021 cosmics workflows.

@tvami
Copy link
Contributor Author

tvami commented Sep 12, 2021

+alca

@tvami
Copy link
Contributor Author

tvami commented Sep 13, 2021

Hi @kskovpen @cms-sw/pdmv-l2 would you mind signing this backport as well? Thanks!

@jordan-martins
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor Author

tvami commented Sep 13, 2021

Hi @qliphy @perrotta we have another PR (the 12_0_X version of #35233) in the pipeline for 12_0_X, would you please merge this asap?

@tvami
Copy link
Contributor Author

tvami commented Sep 13, 2021

urgent

@perrotta
Copy link
Contributor

Hi @qliphy @perrotta we have another PR (the 12_0_X version of #35233) in the pipeline for 12_0_X, would you please merge this asap?

Hi @tvami this can be merged in 12_0_X to allow further backports.
Please notice however that 12_0_1 is currently being built, following a request in that sense from PPD, see #35246

@perrotta
Copy link
Contributor

+1

  • GT updates for Run3 and technical data taking at P5

@cmsbuild cmsbuild merged commit 3aad807 into cms-sw:CMSSW_12_0_X Sep 13, 2021
@tvami
Copy link
Contributor Author

tvami commented Sep 13, 2021

Hi @qliphy @perrotta we have another PR (the 12_0_X version of #35233) in the pipeline for 12_0_X, would you please merge this asap?

Hi @tvami this can be merged in 12_0_X to allow further backports.
Please notice however that 12_0_1 is currently being built, following a request in that sense from PPD, see #35246

Oh I guess it would have been nice to have that PR included there. On the other hand, it's not a must, the GT can be specified from the cmsDriver...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants