Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 11634.7 wf for 2021 ttbar mkFit to the short matrix #35235

Merged
merged 1 commit into from Sep 17, 2021

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Sep 11, 2021

in view of enabling mkFit in tracking some time soon, addition of this workflow to the short matrix should allow to regularly monitor that the workflow is working and the changes in outputs are checked in comparisons.

@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Sep 11, 2021
@slava77 slava77 changed the title add 11634.7 wf for 2021 ttbar mkFit add 11634.7 wf for 2021 ttbar mkFit to the short matrix Sep 11, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35235/25198

  • This PR adds an extra 16KB to repository

@slava77
Copy link
Contributor Author

slava77 commented Sep 11, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @chayanit, @bbilin, @wajidalikhan, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo, @kpedro88 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dc5ef/18511/summary.html
COMMIT: 9c24980
CMSSW: CMSSW_12_1_X_2021-09-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35235/18511/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dc5ef/18511/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dc5ef/18511/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc: In function 'void {anonymous}::setupSteeringParamsIter0(mkfit::IterationConfig&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:35:10: error: 'class mkfit::SteeringParams' has no member named 'set_iterator_limits'
   35 |       sp.set_iterator_limits(2, 0);
      |          ^~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:50:10: error: 'class mkfit::SteeringParams' has no member named 'set_iterator_limits'
   50 |       sp.set_iterator_limits(2, 0);
      |          ^~~~~~~~~~~~~~~~~~~


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:35:10: error: no member named 'set_iterator_limits' in 'mkfit::SteeringParams'
      sp.set_iterator_limits(2, 0);
      ~~ ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:50:10: error: no member named 'set_iterator_limits' in 'mkfit::SteeringParams'
      sp.set_iterator_limits(2, 0);
      ~~ ^


@slava77
Copy link
Contributor Author

slava77 commented Sep 11, 2021

Failed Tests

need to re-test after CMSSW_12_1_X_2021-09-10-2300 is out

@slava77
Copy link
Contributor Author

slava77 commented Sep 11, 2021

@cmsbuild please test

CMSSW_12_1_X_2021-09-11-1100 showed up around 17:30

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dc5ef/18521/summary.html
COMMIT: 9c24980
CMSSW: CMSSW_12_1_X_2021-09-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35235/18521/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000979
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

This is to add new wfs to the short matrix, for PR test.

@slava77
Copy link
Contributor Author

slava77 commented Sep 17, 2021

@cms-sw/pdmv-l2
please check this PR.
Thank you.

@kskovpen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 17, 2021

+1

@cmsbuild cmsbuild merged commit 7d7d1fd into cms-sw:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants