Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3 gex92: Backport some of the geometry diagnostic tools to study ddd/dd4hep geometries in XML and Big XML versions #35257

Merged
merged 1 commit into from Sep 21, 2021

Conversation

bsunanda
Copy link
Contributor

PR description:

Backport some of the geometry diagnostic tools to study ddd/dd4hep geometries in XML and Big XML versions

PR validation:

Ran the scripts to verify the DDD version

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backported from earlier 12_1_X versions

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_0_X.

It involves the following packages:

  • SimG4Core/PrintGeomInfo (simulation)
  • Validation/Geometry (geometry, dqm)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @cvuosalo, @rovere, @apsallid, @lecriste, @ebrondol, @rishabhCMS, @fabiocos, @slomeo, @rbartek this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cvuosalo
Copy link
Contributor

@bsunanda Thanks for the backport. I need it to check for overlaps with the new version of the DDD geometry.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e088e/18569/summary.html
COMMIT: cd786a5
CMSSW: CMSSW_12_0_X_2021-09-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35257/18569/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Sep 14, 2021

+1

@bsunanda
Copy link
Contributor Author

@perrotta @jfernan2 @qliphy Could you please merge this to 12_0_X? It provides all tools to verify geometry

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Backporting updates to test scripts and geometry xml files

@cmsbuild cmsbuild merged commit c204c8a into cms-sw:CMSSW_12_0_X Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants