change "double" to "float" in DataFormats/METReco

[TaiSakuma]

continuing from #3439, this PR changes "double" to "float" in SpecificGenMETData

I made this PR separate from #3439 so #3439 can be still merged even if this PR causes an error

[cmsbuild]

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_1_X.

change "double" to "float" in DataFormats/METReco

It involves the following packages:

DataFormats/METReco
RecoMET/METAlgorithms

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 27-Apr-2014 11:08:27 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'FEVTDEBUGoutput_step'
   [2] Calling event method for module PoolOutputModule/'FEVTDEBUGoutput'
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 27-Apr-2014 11:08:55 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Calling event method for module PoolOutputModule/'FEVTDEBUGHLToutput'
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3529/1103/summary.html

[TaiSakuma]

from the build log https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3529/1103/build.log, not every package that depends on DataFormats/METReco seems to have been recompiled.

I think that it will work if some of the depending packages are recompiled.

In my environment, I will get a fatal fault if I don't recompile DataFormats/PatCandidates. I think that RecoMET/METProducers and JetMETCorrections/Type1MET need to be recompiled as well.

[ktf]

DataFormats should not depend on reco, right?

[ktf]

Sorry, I mis-read your message. I guess we are missing a dependency in DataFormats/PatCandidates

[TaiSakuma]

Just to clarify, I didn't mean that packages that DataFormats/METReco depends on need to be recompiled. I meant the other way, i.e., packages that depend on DataFormats/METReco need to be recompiled.

[ktf]

Not sure what is going on.

Checkdeps only checks out the packages that actually include your
changes (not merely those which are a dependency of the containing
package), so either checkdeps is wrong, or your package depends on those
changes in a weird manner. Investigating.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3529/1122/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3529/1122/summary.html

[slava77]

looking at it

[slava77]

+1

for #3529 57caa63

tested in CMSSW_7_1_X_2014-04-29-0200
( test area sign361 pulls 3475 3529 3531 3550 3555 together)

• old and new objects are still readable.
• DQM shows changes in MET-specific fractions and values at a level of float precision.
• Size of compressed MET branches is down from 5% for GEN to about 30% for CaloMETs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?