Migrate EDModules in RecoPixelVertexing/PixelTrackFitting to esConsumes #35300

makortel · 2021-09-16T00:22:06Z

PR description:

Part of #31061.

Resolves cms-sw/framework-team#271

PR validation:

Code compiles.

cmsbuild · 2021-09-16T00:29:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35300/25311

This PR adds an extra 44KB to repository

cmsbuild · 2021-09-16T00:29:28Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FastSimulation/Tracking (fastsim)
RecoPixelVertexing/PixelLowPtUtilities (reconstruction)
RecoPixelVertexing/PixelTrackFitting (reconstruction)

@civanch, @lveldere, @sbein, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @matt-komm, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2021-09-16T13:24:40Z

@cmsbuild, please test

cmsbuild · 2021-09-16T14:56:54Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b67fb8/18665/summary.html
COMMIT: 7dd8d31
CMSSW: CMSSW_12_1_X_2021-09-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35300/18665/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b67fb8/18665/llvm-analysis/esrget-sa.txt for details.

RelVals

140.53

----- Begin Fatal Exception 16-Sep-2021 16:00:52 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 182124 lumi: 40 event: 1893722 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module CentralityDQM/'CentralityDQM'
   [3] Prefetching for module CentralityProducer/'hiCentrality'
   [4] Prefetching for module CaloTowersCreator/'towerMaker'
   [5] Prefetching for module HBHEIsolatedNoiseReflagger/'hbhereco@cpu'
   [6] Prefetching for module TrackExtrapolator/'trackExtrapolator'
   [7] Prefetching for module TrackListMerger/'hiGeneralTracks'
   [8] Prefetching for module HIMultiTrackSelector/'hiInitialStepSelector'
   [9] Prefetching for module TrackProducer/'hiGlobalPrimTracks'
   [10] Prefetching for module CkfTrackCandidateMaker/'hiPrimTrackCandidates'
   [11] Prefetching for module MeasurementTrackerEventProducer/'MeasurementTrackerEvent'
   [12] Prefetching for module JetCoreClusterSplitter/'siPixelClusters'
   [13] Prefetching for module HIBestVertexProducer/'hiSelectedVertexPreSplitting'
   [14] Prefetching for module HIPixelMedianVtxProducer/'hiPixelMedianVertexPreSplitting'
   [15] Calling method for module PixelTrackProducer/'hiPixel3ProtoTracksPreSplitting'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<PixelTrackCleaner,CkfComponentsRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

140.56

----- Begin Fatal Exception 16-Sep-2021 16:05:00 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 326479 lumi: 7 event: 1394020 stream: 0
   [1] Running path 'dqmoffline_9_step'
   [2] Prefetching for module CentralityDQM/'CentralityDQM'
   [3] Prefetching for module CentralityProducer/'hiCentrality'
   [4] Calling method for module PixelTrackProducer/'hiConformalPixelTracks'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<PixelTrackCleaner,CkfComponentsRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

312.0

----- Begin Fatal Exception 16-Sep-2021 16:10:38 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module DQMMessageLogger/'DQMMessageLogger'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Calling method for module PixelTrackProducer/'hiConformalPixelTracks'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<PixelTrackCleaner,CkfComponentsRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

140.52140.52_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI/step2_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI.log
140.53140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
158.2158.2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 16-Sep-2021 16:03:35 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'HLT_IsoTrackHE_v4'
   [2] Calling method for module PixelTrackProducer/'hltPixelTracks'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<PixelTrackCleaner,CkfComponentsRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 16-Sep-2021 16:08:20 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 1
   [1] Running path 'HLT_IsoTrackHE_v4'
   [2] Calling method for module PixelTrackProducer/'hltPixelTracks'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<PixelTrackCleaner,CkfComponentsRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 16-Sep-2021 16:03:06 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 2
   [1] Running path 'HLT_HIUPC_ZeroBias_SinglePixelTrack_v1'
   [2] Calling method for module PixelTrackProducer/'hltPixelTracksForUPCPPOnAA'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<PixelTrackCleaner,CkfComponentsRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

cmsbuild · 2021-09-16T17:16:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35300/25326

This PR adds an extra 44KB to repository

cmsbuild · 2021-09-17T01:16:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35300/25344

This PR adds an extra 16KB to repository

cmsbuild · 2021-09-17T01:16:45Z

Pull request #35300 was updated. @civanch, @lveldere, @sbein, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @jpata can you please check and sign again.

makortel · 2021-09-17T01:34:24Z

@cmsbuild, please test

cmsbuild · 2021-09-17T05:34:27Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b67fb8/18687/summary.html
COMMIT: f41bfc7
CMSSW: CMSSW_12_1_X_2021-09-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35300/18687/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000833
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000805
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jpata · 2021-09-17T15:12:19Z

+reconstruction

technical, no relevant reco changes (usual ONNX AVX/AVX2 differences)

civanch · 2021-09-17T21:01:23Z

+1

cmsbuild · 2021-09-17T21:01:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-09-18T01:10:35Z

+1

makortel added 4 commits September 15, 2021 22:10

Migrate PixelFitterByConformalMappingAndLineProducer to esConsumes()

b378b53

Migrate PixelFitterByHelixProjectionsProducer to esConsumes

53e9aaf

Remove EventSetup parameter from PixelFitterBase::run()

a7acd32

Migrate KFBasedPixelFitterProducer to esConsumes()

27f3153

makortel mentioned this pull request Sep 16, 2021

Migrate modules in RecoPixelVertexing/PixelTrackFitting to esConsumes cms-sw/framework-team#271

Closed

cmsbuild added this to the CMSSW_12_1_X milestone Sep 16, 2021

cmsbuild added code-checks-pending fastsim-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 16, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 16, 2021

cmsbuild added tests-rejected and removed tests-started labels Sep 16, 2021

makortel force-pushed the esconsumesRecoPixelVertexing branch from 7dd8d31 to 801b94a Compare September 16, 2021 17:08

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Sep 16, 2021

makortel force-pushed the esconsumesRecoPixelVertexing branch from 801b94a to 2d06787 Compare September 16, 2021 17:09

cmsbuild removed the code-checks-pending label Sep 16, 2021

makortel added 2 commits September 17, 2021 03:07

Remove unnecessary ESHandle includes

49ee11e

Migrate PixelTracksProducer to esConsumes

f41bfc7

makortel force-pushed the esconsumesRecoPixelVertexing branch from dd67103 to f41bfc7 Compare September 17, 2021 01:07

cmsbuild added code-checks-pending and removed code-checks-approved labels Sep 17, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 17, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 17, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 17, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 17, 2021

cmsbuild added fastsim-approved fully-signed and removed fastsim-pending pending-signatures labels Sep 17, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 18, 2021

cmsbuild merged commit aeb2739 into cms-sw:master Sep 18, 2021

makortel deleted the esconsumesRecoPixelVertexing branch September 18, 2021 01:18

cmsbuild mentioned this pull request Sep 20, 2021

Update Geant4 to 10.7.2 cms-sw/cmsdist#7316

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate EDModules in RecoPixelVertexing/PixelTrackFitting to esConsumes #35300

Migrate EDModules in RecoPixelVertexing/PixelTrackFitting to esConsumes #35300

makortel commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

makortel commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

makortel commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

jpata commented Sep 17, 2021

civanch commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

qliphy commented Sep 18, 2021

Migrate EDModules in RecoPixelVertexing/PixelTrackFitting to esConsumes #35300

Migrate EDModules in RecoPixelVertexing/PixelTrackFitting to esConsumes #35300

Conversation

makortel commented Sep 16, 2021

PR description:

PR validation:

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

makortel commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

RelVals

RelVals-INPUT

AddOn Tests

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

makortel commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

Comparison Summary

jpata commented Sep 17, 2021

civanch commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

qliphy commented Sep 18, 2021