Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 12_0_X] Fix for SiPixelRecHitFromCUDA crash during online GPU tests #35317

Conversation

czangela
Copy link
Contributor

PR description:

See description at #35229.

With this backport the issues in #34831 should be addressed. As far as I understand, backport to 12_0_X is sufficient for later purposes.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

#35229

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 17, 2021

A new Pull Request was created by @czangela for CMSSW_12_0_X.

It involves the following packages:

  • CUDADataFormats/SiPixelCluster (heterogeneous, reconstruction)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@makortel, @jpata, @cmsbuild, @fwyzard, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Sep 17, 2021

backport #35229

@fwyzard
Copy link
Contributor

fwyzard commented Sep 17, 2021

type bugfix

@fwyzard
Copy link
Contributor

fwyzard commented Sep 17, 2021

please test

@fwyzard
Copy link
Contributor

fwyzard commented Sep 17, 2021

+heterogeneous

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30573d/18704/summary.html
COMMIT: fc76746
CMSSW: CMSSW_12_0_X_2021-09-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35317/18704/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Sep 20, 2021

+reconstruction

for #35317 fc76746

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants