More diagnostic plots for CSC trigger primitives in validation step #35329

dildick · 2021-09-18T03:05:03Z

PR description:

New class to plot CSC TP position and bending resolutions in release validation. Plots are made for CLCT bending resolution, and CLCT 1/2-strip, 1/4-strip and 1/8-strip resolution. The latter two only make sense for chambers that have the CCLUT algorithm enabled (MEX/1 in the baseline commissioning model).

I also added diagnostic plots for ALCT, CLCT, CLCT pre-trigger, and LCT for each chamber type and for each endcap (sometimes we see asymmetries in the performance). I borrowed a lot of code from the L1T CSC DQM tools which I wrote earlier this year. I organized the plots by object, and by type of plot, so it's not all in one directory. The screenshot below shows the directory structure (tested on 100 1TeV muon events). Not every object has each type of plot. E.g. I don't have resolution plots for ALCTs.

This PR is part of an investigation into the EMTF performance for 1 TeV muons with Run-3 CSC trigger primitives.

PR validation:

Ran 1000 events from /RelValSingleMuPt1000/CMSSW_12_0_0_pre4-120X_mcRun3_2021_realistic_v2-v1/GEN-SIM-DIGI-RAW with

cmsRun Validation/MuonCSCDigis/test/runCSCDigiValidation_cfg.py
cmsRun Validation/MuonCSCDigis/test/runCSCDigiHarvesting_cfg.py

Plots should automatically appear in MuonCSCDigisV/CSCDigiTask/Stub/Resolution/. I added a few examples below

if this PR is a backport please specify the original PR and why you need to backport that PR:

N.A.

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

FYI @ptcox @AFJohan92

dildick · 2021-09-18T03:07:44Z

Examples of position resolutions (ME1/a and ME1/b are split up)

cmsbuild · 2021-09-18T03:12:44Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35329/25374

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35329/25374/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35329/25374/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2021-09-18T03:26:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35329/25375

This PR adds an extra 24KB to repository

cmsbuild · 2021-09-18T03:26:52Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

Validation/MuonCSCDigis (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-09-20T07:25:02Z

please test

cmsbuild · 2021-09-20T08:43:18Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3372e/18751/summary.html
COMMIT: 036bfec
CMSSW: CMSSW_12_1_X_2021-09-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35329/18751/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

5.1

----- Begin Fatal Exception 20-Sep-2021 09:47:16 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCRecHitValidation label='cscRecHitValidation'
Exception Message:
MissingParameter: ParameterSet 'simTrack' not found.
----- End Fatal Exception -------------------------------------------------

135.4

----- Begin Fatal Exception 20-Sep-2021 09:47:19 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCRecHitValidation label='cscRecHitValidation'
Exception Message:
MissingParameter: ParameterSet 'simTrack' not found.
----- End Fatal Exception -------------------------------------------------

9.0

----- Begin Fatal Exception 20-Sep-2021 09:54:27 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCRecHitValidation label='cscRecHitValidation'
Exception Message:
MissingParameter: ParameterSet 'simTrack' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

AddOn Tests

fastsim

----- Begin Fatal Exception 20-Sep-2021 09:47:06 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCRecHitValidation label='cscRecHitValidation'
Exception Message:
MissingParameter: ParameterSet 'simTrack' not found.
----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 20-Sep-2021 09:47:06 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCRecHitValidation label='cscRecHitValidation'
Exception Message:
MissingParameter: ParameterSet 'simTrack' not found.
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 20-Sep-2021 09:47:06 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCRecHitValidation label='cscRecHitValidation'
Exception Message:
MissingParameter: ParameterSet 'simTrack' not found.
----- End Fatal Exception -------------------------------------------------

cmsbuild · 2021-09-21T01:01:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35329/25414

This PR adds an extra 12KB to repository

cmsbuild · 2021-09-21T01:01:31Z

Pull request #35329 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2021-09-29T16:52:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35329/25636

This PR adds an extra 80KB to repository

cmsbuild · 2021-09-29T16:53:24Z

Pull request #35329 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

jfernan2 · 2021-09-29T16:54:35Z

please test

dildick · 2021-09-29T17:02:41Z

I was able to run WF 11634.0

11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Sep 29 11:31:25 2021-date Wed Sep 29 11:13:08 2021; exit: 0 0 0 0 0
1 1 1 1 1 tests passed, 0 0 0 0 0 failed

quartstripbit and eighthstripbit plots were removed.
I added a plot for the pre-CLCT CFEB, but removed pre-CLCT pattern, bending, and quality. Overall, a reduction in number of 108 plots.

cmsbuild · 2021-09-29T22:40:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3372e/19251/summary.html
COMMIT: f8bcf35
CMSSW: CMSSW_12_1_X_2021-09-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35329/19251/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3372e/19251/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3372e/19251/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 3206240
DQMHistoTests: Total failures: 27
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3206190
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3325.803 KiB( 39 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 104.390 KiB MuonCSCDigisV/CSCDigiTask
DQMHistoSizes: changed ( 11634.0,... ): 207.312 KiB MuonCSCDigisV/CSCDigiTask
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-09-30T07:01:00Z

+1
~400 new MEs added accounting for ~200KiB in memory, they are needed for trigger primitives validation

cmsbuild · 2021-09-30T07:01:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

dildick · 2021-09-30T14:42:01Z

@qliphy Can you sign off, please?

qliphy · 2021-10-01T00:11:05Z

+1

Dr15Jones · 2021-10-02T14:23:26Z

It seems highly likely that this change introduced a call to a thread-unsafe ROOT function which is causing jobs in the IB RelVals to fail with

----- Begin Fatal Exception 02-Oct-2021 09:15:32 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module CSCDigiValidation/'cscDigiValidation'
   Additional Info:
      [a] Fatal Root Error: @SUB=TF1::AddToGlobalList
Function is supposed to be in the global list but it is not present

----- End Fatal Exception -------------------------------------------------

dildick · 2021-10-02T14:42:58Z

@Dr15Jones It's not obvious to me which ROOT function is doing that. If you have an idea, let me know, and I will try to address it.

Dr15Jones · 2021-10-02T14:44:03Z

The problem is almost certainly here

cmssw/Validation/MuonHits/src/CSCSimHitMatcher.cc

Lines 239 to 240 in 6d2f660

    
           std::unique_ptr<TF1> fit(new TF1("fit", "pol1", -3, 4)); 
        
           gr->Fit("fit", "EMQ");

See #18370 for the resolution of the same problem.

dildick · 2021-10-04T12:32:20Z

I will submit a fix.

cmsbuild added this to the CMSSW_12_1_X milestone Sep 18, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Sep 18, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Sep 18, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 18, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 20, 2021

cmsbuild added tests-rejected code-checks-pending tests-pending and removed tests-started tests-rejected code-checks-approved labels Sep 20, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 21, 2021

cmsbuild added the tests-pending label Sep 29, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 29, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 29, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 29, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Sep 30, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 1, 2021

cmsbuild merged commit 253edee into cms-sw:master Oct 1, 2021

dildick deleted the from-CMSSW_12_1_X_2021-09-16-2300-cscstubresolutionvalidation branch October 1, 2021 02:47

dildick mentioned this pull request Oct 4, 2021

Fix thread-safety problems with CSC simhit fitting in validation #35528

Merged

dan131riley mentioned this pull request Oct 4, 2021

CSCDigiValidation leads to an exception in TF1::AddToGlobalList #35529

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More diagnostic plots for CSC trigger primitives in validation step #35329

More diagnostic plots for CSC trigger primitives in validation step #35329

dildick commented Sep 18, 2021 •

edited

dildick commented Sep 18, 2021

cmsbuild commented Sep 18, 2021

cmsbuild commented Sep 18, 2021

cmsbuild commented Sep 18, 2021

jfernan2 commented Sep 20, 2021

cmsbuild commented Sep 20, 2021

cmsbuild commented Sep 21, 2021

cmsbuild commented Sep 21, 2021

cmsbuild commented Sep 29, 2021

cmsbuild commented Sep 29, 2021

jfernan2 commented Sep 29, 2021

dildick commented Sep 29, 2021

cmsbuild commented Sep 29, 2021

jfernan2 commented Sep 30, 2021

cmsbuild commented Sep 30, 2021

dildick commented Sep 30, 2021

qliphy commented Oct 1, 2021

Dr15Jones commented Oct 2, 2021

dildick commented Oct 2, 2021

Dr15Jones commented Oct 2, 2021

dildick commented Oct 4, 2021

More diagnostic plots for CSC trigger primitives in validation step #35329

More diagnostic plots for CSC trigger primitives in validation step #35329

Conversation

dildick commented Sep 18, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

dildick commented Sep 18, 2021

cmsbuild commented Sep 18, 2021

cmsbuild commented Sep 18, 2021

cmsbuild commented Sep 18, 2021

jfernan2 commented Sep 20, 2021

cmsbuild commented Sep 20, 2021

RelVals

AddOn Tests

cmsbuild commented Sep 21, 2021

cmsbuild commented Sep 21, 2021

cmsbuild commented Sep 29, 2021

cmsbuild commented Sep 29, 2021

jfernan2 commented Sep 29, 2021

dildick commented Sep 29, 2021

cmsbuild commented Sep 29, 2021

Comparison Summary

jfernan2 commented Sep 30, 2021

cmsbuild commented Sep 30, 2021

dildick commented Sep 30, 2021

qliphy commented Oct 1, 2021

Dr15Jones commented Oct 2, 2021

dildick commented Oct 2, 2021

Dr15Jones commented Oct 2, 2021

dildick commented Oct 4, 2021

dildick commented Sep 18, 2021 •

edited