Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup writing with confdb.py for HLT #35369

Merged
merged 1 commit into from Sep 23, 2021

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Fix setup writing with confdb.py for HLT, as suggested by David Sperka

PR validation:

Explicit test - script now works!

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #35368 - fix for user script supporting HLT work

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2021

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_12_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @missirol, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

type bugfix

@Martin-Grunewald
Copy link
Contributor Author

backport of #35368

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c7b3b/18836/summary.html
COMMIT: 1579044
CMSSW: CMSSW_12_0_X_2021-09-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35369/18836/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998524
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 23, 2021

+1

@cmsbuild cmsbuild merged commit 1cee206 into cms-sw:CMSSW_12_0_X Sep 23, 2021
@Martin-Grunewald Martin-Grunewald deleted the confdbFix120X branch October 27, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants