Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix offline BS swap for express Run3 #35373

Merged
merged 7 commits into from Sep 29, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 22, 2021

PR description:

Address discussion at #35334 (comment).

PR validation:

Run successfully wf 138.2 with: runTheMatrix.py -l 138.2 -j 8 -t 4 and verified the configuration looks as it should:

$edmConfigDump step2_RAW2DIGI_L1Reco_RECO_DQM.py > dump.py
$more dump.py | grep -A 5 OnlineBeamSpotESProducer
process.BeamSpotESProducer = cms.ESProducer("OnlineBeamSpotESProducer",
    appendToDataLabel = cms.string(''),
    sigmaZThreshold = cms.double(2),
    timeThreshold = cms.int32(48)
)

$more dump.py | grep useTransientRecord
    useTransientRecord = cms.bool(True)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but a backport to 12_0_X is needed.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35373/25451

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@perrotta, @malbouis, @yuanchao, @davidlange6, @cmsbuild, @slava77, @jpata, @qliphy, @francescobrivio, @fabiocos, @tvami can you please review it and eventually sign? Thanks.
@fabiocos, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @tocheng, @mmusich, @mtosi, @dgulhan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2021

please test

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2021

I realized that the inclusion of

 BeamSpotESProducer = cms.ESProducer("OnlineBeamSpotESProducer")

in RecoVertex/BeamSpotProducer/python/BeamSpotOnline_cff.py is necessary to make the DQM unit tests to pass (see log)

@francescobrivio
Copy link
Contributor

@gennai @mzarucki I'm not sure how do you import the BeamSpotOnline ESProducer in the hlt menu, just be aware that the _cffand _cfi files are being modified here.

@francescobrivio
Copy link
Contributor

@mmusich is this still a draft?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35373/25454

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@AdrianoDee
Copy link
Contributor

+Upgrade

@jfernan2
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

For the upgrade part, update to the defined GT on DD4hep.

@bbilin
Copy link
Contributor

bbilin commented Sep 28, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Sep 29, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet