Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFVal on-the-fly operation update for CMSSW_12_1 #35382

Merged
merged 12 commits into from Sep 24, 2021

Conversation

hatakeyamak
Copy link
Contributor

PR description:

Updating the dataset lists and scripts so that we can run PF validation on-the-fly under CMSSW_12_1.

The workflow based on crab still doesn't run due to issue discussed here https://hypernews.cern.ch/HyperNews/CMS/get/computing-tools/6160/2/1/1/1/1/1/1.html, but the condor-based workflow runs ok.

PR validation:

Used this branch to test some developmental branch such as #35309.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not backport.

@akanugan @kdlong @juska @laurenhay @marksan87

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35382/25473

  • This PR adds an extra 32KB to repository

  • Found files with invalid states:

    • Validation/RecoParticleFlow/test/TenTauPU.jdl:
    • Validation/RecoParticleFlow/test/NuGunPU.jdl:
    • Validation/RecoParticleFlow/test/ZMMPU.jdl:
    • Validation/RecoParticleFlow/test/ZEEPU.jdl:
  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master.

It involves the following packages:

  • Validation/RecoParticleFlow (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad7088/18873/summary.html
COMMIT: c35993a
CMSSW: CMSSW_12_1_X_2021-09-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35382/18873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211058
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17d8742 into cms-sw:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants