Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fixes on PPS geometry #35391

Merged
merged 10 commits into from Sep 25, 2021
Merged

Conversation

diemort
Copy link
Contributor

@diemort diemort commented Sep 23, 2021

PR description:

This is a backport of #35380 to CMSSW_12_0_1.

This PR addresses a few minor corrections on the PPS geometry in the Pixel sensors and complies the material names in the reco geometry as stated in #34927. The position of the Silicon wafers has been move down to 250um w.r.t. the bottom foil and the envelopes with sensors ad flexible cables has been enlarged to avoid volume overlaps. Besides, the U shape of the Aluminum supports has been changed to a plain squared piece. A detailed list of the file changes and visualization of the new changes in the Pixel sensors is given in this twiki.

Includes updated on both DDD and dd4hep files and keeps the default dict2021Geometry.py for 12_0.

PR validation:

The new changes in the geometry have been validated with the full CMS geometry dump for visualization and overlap check with tolerance 0.01, plus direct and full simulation to confirm hits in both pixel and timing detectors. The position of the pixel sensors have been checked with direct simulation here.

if this PR is a backport please specify the original PR and why you need to backport that PR:

PR #35380, needed to update PPS geometry for Run3.

All changes follow the Naming Rules for new XML files in geometry.
All workflow tests done.

FYI @fabferro @jan-kaspar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2021

A new Pull Request was created by @diemort (Gustavo Silveira) for CMSSW_12_0_X.

It involves the following packages:

  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/VeryForwardData (geometry)
  • Geometry/VeryForwardGeometry (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@bsunanda, @fabferro, @jan-kaspar, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #35391 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #35391 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

@diemort
Copy link
Contributor Author

diemort commented Sep 23, 2021

Remaining dict2021 files removed.

@bsunanda
Copy link
Contributor

@diemort You should not have deleted those files - just substitute the ones from CMSSW_RELEASE_BASE area

@bsunanda
Copy link
Contributor

Those files were there in the release base and let them stay as they were like dict2021

@cmsbuild
Copy link
Contributor

Pull request #35391 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Sep 24, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef5e8e/18879/summary.html
COMMIT: 7504331
CMSSW: CMSSW_12_0_X_2021-09-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35391/18879/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998530
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Sep 24, 2021

+1

@civanch
Copy link
Contributor

civanch commented Sep 24, 2021

urgent

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #35380

@perrotta
Copy link
Contributor

+1

  • It adds to 12_0_X the xml files containing the updates for the PPS geometry, without modifying the default dict2021Geometry.py

@cmsbuild cmsbuild merged commit eed117e into cms-sw:CMSSW_12_0_X Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants