GEM unpacker - allow custom FEDIDs to be unpacked

[jshlee]

The GEM unpacker is used outside of p5 in the cosmic stand test and test beam.
However, the FEDIDs used are not always the same as the values defined in FEDNumbering.

• added fedIdStart and fedIdEnd vars to configurable so that this unpacker can be easily used in other applications
• no changes expected

tested with wf 11611.0

no backport is required.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35429/25558

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jshlee (Jason Lee) for master.

It involves the following packages:

• EventFilter/GEMRawToDigi (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jshlee]

can I get this tested please

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d6250/19249/summary.html
COMMIT: 63bdc82
CMSSW: CMSSW_12_1_X_2021-09-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35429/19249/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jpata]

I note that there are a few other places in the codebase where FEDNumbering::MINGEMFEDID is used but not configurable.

• EventFilter/GEMRawToDigi/plugins/GEMPackingTester.cc
• EventFilter/GEMRawToDigi/plugins/GEMDigiToRawModule.cc
• CondFormats/GEMObjects/src/GEMeMap.cc
• CondCore/RunInfoPlugins/interface/RunInfoPayloadInspectoHelper.h

Do you need to propagate this configurability to any of those places?

[jshlee]

I note that there are a few other places in the codebase where FEDNumbering::MINGEMFEDID is used but not configurable.

• EventFilter/GEMRawToDigi/plugins/GEMPackingTester.cc
• EventFilter/GEMRawToDigi/plugins/GEMDigiToRawModule.cc
• CondFormats/GEMObjects/src/GEMeMap.cc
• CondCore/RunInfoPlugins/interface/RunInfoPayloadInspectoHelper.h

Do you need to propagate this configurability to any of those places?

Hi @jpata, we don't currently foresee the need yet.

[jpata]

+reconstruction

• for 63bdc82
• technical, makes fedIdStart, fedIdEnd configurable in GEMRawToDigi, defaults as before
• no reco changes expected/observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1