New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include final DDD geometry in Run-3 GTs #35479
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35479/25643
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
@smuzaffar @qliphy @perrotta the comparison test is still in "pending" status after ~7 hours. Is it stuck? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a7ed0/19261/summary.html Comparison SummarySummary:
|
Never mind this message: the comparison ended just a minute after I posted this! 🤣 |
yes the comparison job just finished 3 mins ago ( https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/45853/ ) |
Since the XMLFILE_Geometry tag is updated with the final Run3 12_1 DDD geometry I believe the differences in the comparison tests are expected. |
Yes, I can confirm that no regression is expected. |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
After PPS geometry revisions, the final Run 3 12_1 DDD geometry is ready. Changes in the geometry:
The new GTs and the diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v6/121X_mcRun3_2021_design_v7
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v8/121X_mcRun3_2021_realistic_v9
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v8/121X_mcRun3_2021cosmics_realistic_deco_v9
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v8/121X_mcRun3_2021_realistic_HI_v9
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v7/121X_mcRun3_2023_realistic_v8
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v7/121X_mcRun3_2024_realistic_v8
The diffs are only in the requested
XMLFILE_Geometry_121YV1_Extended2021_mc
tagHN msg:
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4475/2.html
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is not a backport and no backport is expected
cc @cms-sw/geometry-l2