Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include final DDD geometry in Run-3 GTs #35479

Merged
merged 1 commit into from Oct 1, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Sep 30, 2021

PR description:

After PPS geometry revisions, the final Run 3 12_1 DDD geometry is ready. Changes in the geometry:

The new GTs and the diffs:

The diffs are only in the requested
XMLFILE_Geometry_121YV1_Extended2021_mc tag

HN msg:
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4475/2.html

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport and no backport is expected

cc @cms-sw/geometry-l2

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35479/25643

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Sep 30, 2021

@cmsbuild , please test

@francescobrivio
Copy link
Contributor

@smuzaffar @qliphy @perrotta the comparison test is still in "pending" status after ~7 hours. Is it stuck?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a7ed0/19261/summary.html
COMMIT: fdc1ec3
CMSSW: CMSSW_12_1_X_2021-09-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35479/19261/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10390 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 86239
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3124819
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: found differences in 4 / 39 workflows

@francescobrivio
Copy link
Contributor

@smuzaffar @qliphy @perrotta the comparison test is still in "pending" status after ~7 hours. Is it stuck?

Never mind this message: the comparison ended just a minute after I posted this! 🤣

@smuzaffar
Copy link
Contributor

yes the comparison job just finished 3 mins ago ( https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/45853/ )

@francescobrivio
Copy link
Contributor

Since the XMLFILE_Geometry tag is updated with the final Run3 12_1 DDD geometry I believe the differences in the comparison tests are expected.
@cms-sw/geometry-l2 please confirm.

@civanch
Copy link
Contributor

civanch commented Sep 30, 2021

Yes, I can confirm that no regression is expected.

@francescobrivio
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 1, 2021

+1

@cmsbuild cmsbuild merged commit 7a740e6 into cms-sw:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants