Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates in CSC TP configurations for B904 tests #35496

Merged
merged 4 commits into from Oct 8, 2021
Merged

Minor updates in CSC TP configurations for B904 tests #35496

merged 4 commits into from Oct 8, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Sep 30, 2021

PR description:

@jfernan2 Recall that I recently closed #34780 without merging it, because I did not want to introduce additional emulator changes while we're still investigating the performance of the Run-3 trigger primitives in the forward region for high-pT muons. Nevertheless PR #34780 does have a few updates for our B904 test-stands. In particular we are testing the Run-3 firmware for ME2/1 this week (and the DMBSlot2 in currently wrong).

PR validation:

Code compiles. Only test configurations.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35496/25666

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35496/25668

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

  • IORawData/CSCCommissioning (daq)
  • L1Trigger/CSCTriggerPrimitives (l1)

@cmsbuild, @rekovic, @emeschi, @cecilecaillol, @smorovic can you please review it and eventually sign? Thanks.
@valuev, @missirol, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c14fcc/19300/summary.html
COMMIT: 0d2993e
CMSSW: CMSSW_12_1_X_2021-09-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35496/19300/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1000 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 2568
  • DQMHistoTests: Total nulls: 62
  • DQMHistoTests: Total successes: 3208428
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 65.355 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 63.680 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 1.676 KiB RPC/DCSInfo
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 1, 2021

+1

1 similar comment
@smorovic
Copy link
Contributor

smorovic commented Oct 1, 2021

+1

@rekovic
Copy link
Contributor

rekovic commented Oct 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 8, 2021

please test
try again before final merging

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c14fcc/19487/summary.html
COMMIT: 0d2993e
CMSSW: CMSSW_12_1_X_2021-10-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35496/19487/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219372
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Oct 8, 2021

+1

@cmsbuild cmsbuild merged commit 6062579 into cms-sw:master Oct 8, 2021
@dildick dildick deleted the from-CMSSW_12_1_X_2021-09-30-1100-CSC-test-DQM-configurations branch October 8, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants