Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert MuonShowerInformationProducer back to legacy #3555

Conversation

Dr15Jones
Copy link
Contributor

MuonShowerInformationProducer was missed when we reverted all modules
using MuonDetLayerGeometry back to legacy to avoid thread safety
problems.

MuonShowerInformationProducer was missed when we reverted all modules
using MuonDetLayerGeometry back to legacy to avoid thread safety
problems.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Revert MuonShowerInformationProducer back to legacy

It involves the following packages:

RecoMuon/MuonIdentification

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Apr 29, 2014

 * [new ref]                    -> merge-attempt
fatal: Couldn't find remote ref refs/pull/3550/head
Unexpected end of command stream

what's going on?

@Dr15Jones
Copy link
Contributor Author

@ktf any ideas?

@Dr15Jones
Copy link
Contributor Author

@nclopezo has the test for this been started?

@nclopezo
Copy link
Contributor

Hi @Dr15Jones,

Yes, but I had troubles with git as well. I had to use the branch name for git cms-merge-topic and I will post the results by hand as soon as they finish.

When I do

git ls-remote official-cmssw

I only see c8bb0ba refs/pull/3555/merge
but not
refs/pull/3555/head

The same happens with #3550

@Dr15Jones
Copy link
Contributor Author

Yesterday, when I made the pull requests, github had web server errors but the pull request appeared to go through.

@slava77
Copy link
Contributor

slava77 commented Apr 30, 2014

+1

for #3555 114a11a

tested in CMSSW_7_1_X_2014-04-29-0200
( test area sign361 pulls 3475 3529 3531 3550 3555 together)
no regressions here.
Still had to merge manually from Chris' branch

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 30, 2014
…oducerBackToLegacy

Multithreading -- Revert MuonShowerInformationProducer back to legacy
@ktf ktf merged commit b06e2f6 into cms-sw:CMSSW_7_1_X Apr 30, 2014
@Dr15Jones Dr15Jones deleted the revertMuonShowerInformationProducerBackToLegacy branch May 6, 2014 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants