Proposed solution to ECAL emulator PR issue

[atishelmanch]

PR description:

The purpose of this pull request is to address issue #33425, raised after merging the ECAL emulator update PR #33349. This PR proposes two solutions to the issue:

1. Non-thread-safe cout statements are replaced with LogVerbatim or LogInfo.
2. Previously caught exceptions are now rethrown as cms exceptions.

PR validation:

• All runTheMatrix tests have passed
• Code checks and code formatting applied in commits
• Tested each step of the way and successfully ran with an ECAL trigger cmssw configuration file [1]

cc: @thomreis @valsdav

[1] https://github.com/CMS-ECAL-Trigger-Group/ETTAnalyzer

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35557/25790

• This PR adds an extra 216KB to repository

[cmsbuild]

A new Pull Request was created by @atishelmanch (Abraham Tishelman-Charny ) for master.

It involves the following packages:

• CondFormats/EcalObjects (db, alca)
• CondTools/Ecal (db)
• OnlineDB/EcalCondDB (db)
• SimCalorimetry/EcalTrigPrimAlgos (l1)

@malbouis, @yuanchao, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @rovere, @argiro, @tocheng, @thomreis, @simonepigazzini, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32689a/19439/summary.html
COMMIT: 5960e9e
CMSSW: CMSSW_12_1_X_2021-10-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35557/19439/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

• 4.22DAS Error

[atishelmanch]

Hello - As I understand, the error coming from "cms/35557/slc7_amd64_gcc900/relvals" does not appear to be related to the changed proposed in this PR, since it is a DAS error. Should the tests be rerun?

[tvami]

@cmsbuild , please test

[cmsbuild]

Pull request #35557 was updated. @malbouis, @yuanchao, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32689a/19545/summary.html
COMMIT: 912bc18
CMSSW: CMSSW_12_1_X_2021-10-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35557/19545/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2798082
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2798048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• see Proposed solution to ECAL emulator PR issue  #35557 (comment)

[rekovic]

+1

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• As already mentioned in Proposed solution to ECAL emulator PR issue  #35557 (comment). it would be wise to solve all the (many) issues reported by the Static Analizer. Ok for having it done in a different PR