Make Geant4 geometry exception to be just a warning

[civanch]

PR description:

In mass production just running with 12_0_2 there are number of rare exceptions due to problem in Geant4 navigation at boundaries of some volumes. In this PR these exceptions are converted to warnings.

Handling of Geant4 exception is changed: for each exception a dump of track parameters is added. This is needed, because not in all Geant4 exceptions G4Track information is given, or is given incomplete.

Introduce a new energy threshold. If a particle has kinetic energy blow the GeomNav0003 exceptions become JustWarning, track is killed, simulation continues.

PR validation:

private

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35572/25815

• This PR adds an extra 12KB to repository

• Found files with invalid states:

  • Traceback (most recent call last):
    • File "/build/cmsbld/jenkins/workspace/run-pr-code-checks/cms-bot/process-pull-request", line 37, in
      • for c in pr.get_commits():
    • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/PaginatedList.py", line 49, in iter
      • newElements = self._grow()
    • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/PaginatedList.py", line 61, in _grow
      • newElements = self._fetchNextPage()
    • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/PaginatedList.py", line 162, in _fetchNextPage
      • headers=self.__headers
    • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Requester.py", line 172, in requestJsonAndCheck
      • return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
    • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/shared/github/Requester.py", line 180, in __check
      • raise self.__createException(status, responseHeaders, output)
  • github.GithubException.UnknownObjectException: 404 {u'documentation_url': u'https://docs.github.com/rest/reference/pulls#list-commits-on-a-pull-request', u'message': u'Not Found'}

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35572/25815/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35572/25815/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[civanch]

@bsunanda , @srimanob, I propose this PR to address problems seen to large statistic production reported recently by Phat. From my point of view the problem in navigation is marginal - low-energy e+- cannot path curved boundaries (like cone) in magnetic field. These low-energy electrons basically not needed. Unfortunately, locally I do not have enough statistics to check if this PR is the best solution. I continue local tests.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35572/25816

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-027c09/19468/summary.html
COMMIT: 53267c3
CMSSW: CMSSW_12_1_X_2021-10-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35572/19468/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3219394
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219372
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35572/25866

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #35572 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-027c09/19526/summary.html
COMMIT: 4b2e405
CMSSW: CMSSW_12_1_X_2021-10-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35572/19526/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2798082
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2798060
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[civanch]

+1

This variant is final - we improve all Geant4 Exceptions and switch to warning GeomNav0003 type for low-energy particles.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[srimanob]

There is a question at
https://cms-talk.web.cern.ch/t/simg4coreapplication-exception-in-generation-of-event/7251/6
if this PR should be backported to UL release. @tvami @civanch