Remove obsolete signals from ActivityRegistry

[Dr15Jones]

PR description:

The last Services trying to use those signals were removed from CMSSW.

PR validation:

After doing git cms-checkdeps -a the code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35591/25844

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/ServiceRegistry (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57cc2c/19500/summary.html
COMMIT: 4464dfd
CMSSW: CMSSW_12_1_X_2021-10-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35591/19500/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/FWTGeoRecoGeometryESProducer.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/FWTGeoRecoGeometryRecord.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/Reg_TGeoManager.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/TGeoFromDddService.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/TGeoFromDddService.cc: In constructor 'TGeoFromDddService::TGeoFromDddService(const edm::ParameterSet&, edm::ActivityRegistry&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/TGeoFromDddService.cc:63:6: error: 'class edm::ActivityRegistry' has no member named 'watchPostBeginRun'; did you mean 'watchPostBeginJob'?
   63 |   ar.watchPostBeginRun(this, &TGeoFromDddService::postBeginRun);
      |      ^~~~~~~~~~~~~~~~~
      |      watchPostBeginJob
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/TGeoFromDddService.cc:64:6: error: 'class edm::ActivityRegistry' has no member named 'watchPostEndRun'; did you mean 'watchPostEndJob'?
   64 |   ar.watchPostEndRun(this, &TGeoFromDddService::postEndRun);


[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57cc2c/19508/summary.html
COMMIT: 4464dfd
CMSSW: CMSSW_12_1_X_2021-10-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35591/19508/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/FWTGeoRecoGeometryESProducer.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/FWTGeoRecoGeometryRecord.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/Reg_TGeoManager.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/TGeoFromDddService.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/TGeoFromDddService.cc: In constructor 'TGeoFromDddService::TGeoFromDddService(const edm::ParameterSet&, edm::ActivityRegistry&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/TGeoFromDddService.cc:63:6: error: 'class edm::ActivityRegistry' has no member named 'watchPostBeginRun'; did you mean 'watchPostBeginJob'?
   63 |   ar.watchPostBeginRun(this, &TGeoFromDddService::postBeginRun);
      |      ^~~~~~~~~~~~~~~~~
      |      watchPostBeginJob
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-08-1100/src/Fireworks/Geometry/src/TGeoFromDddService.cc:64:6: error: 'class edm::ActivityRegistry' has no member named 'watchPostEndRun'; did you mean 'watchPostEndJob'?
   64 |   ar.watchPostEndRun(this, &TGeoFromDddService::postEndRun);


[Dr15Jones]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57cc2c/19521/summary.html
COMMIT: 4464dfd
CMSSW: CMSSW_12_1_X_2021-10-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35591/19521/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2798082
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2798060
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1