Misc changes in SiPixel CPE object code in CondTools/SiPixel

[tvami]

PR description:

• Fix "'U' mode is deprecated" message when reading in files. The default now contains the 'U' mode.
• Other py3 related changes for SiPixel2DTemplateDBObjectUploader_cfg.py with some other cleaning
• Also make the printouts a bit more concise as the unit tests were really dominated by the CPE printouts
• I'll deal with the "Assigned value is undefined" SA warning a bit later, this is just for a char array not being initialized

PR validation:

scramv1 b runtests runs fine

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35604/25869

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• CondTools/SiPixel (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72693/19530/summary.html
COMMIT: 93e8741
CMSSW: CMSSW_12_1_X_2021-10-10-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35604/19530/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2798082
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2798054
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

• Jenkins diffs in MsgLogger only
• Unit test now doesn't have the deprecated warning and is somewhat more concise:
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72693/19530/unitTests/src/CondTools/SiPixel/test/testPixelDBs/testing.log

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1