Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong operator. #3562

Merged
merged 1 commit into from Apr 30, 2014
Merged

Fix wrong operator. #3562

merged 1 commit into from Apr 30, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Apr 29, 2014

No description provided.

@ktf
Copy link
Contributor Author

ktf commented Apr 29, 2014

commondataformat3 && 0xF is always 1. I suspect what was actually meant is the &.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Fix wrong operator.

It involves the following packages:

EventFilter/HcalRawToDigi

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 30, 2014

+1

for #3562 d277df2
based on jenkins
the value doesn't seem to be used anywhere

@abdoulline Salavat, could you please comment if anything was actually adversely affected in the past.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Apr 30, 2014
EventFilter/HcalRawToDigi -- Fix wrong operator.
@nclopezo nclopezo merged commit 40e489e into cms-sw:CMSSW_7_1_X Apr 30, 2014
@abdoulline
Copy link

Hi Slava,

I'm not aware of any issues in the past related to this "typo"...
There is even a matching between DCC (for which the fix is now appied) and
HTR OrbitNumber in
http://cmslxr.fnal.gov/lxr/source/DQM/HcalMonitorTasks/src/HcalRawDataMonitor.cc?v=CMSSW_7_1_0_pre7#933
and I don't remember issuses...

Salavat

On Wed, 30 Apr 2014, Slava Krutelyov wrote:

+1

for #3562 d277df2
based on jenkins
the value doesn't seem to be used anywhere

@abdoulline Salavat, could you please comment if anything was actually adversely affected in the past.


Reply to this email directly or view it onGitHub.[5010650__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNDQ3MzM5MCwiZGF0YSI6eyJpZCI6MzEwMTU5N
jF9fQ==--f16452811aeda9e1d706a04dcac0da518a9093b8.gif]

@abdoulline
Copy link

...have received a prompt confirmation (no effect from this typo in the 

past) from Jeremy Mans:
<...>
No effect at all. The high bits of the orbit number were never used for
anything. The matching between DCC and HTR is done on only a few of the
lowest bits, which weren't affected.
<...>

On Wed, 30 Apr 2014, Salavat Abdoulline wrote:

Hi Slava,

I'm not aware of any issues in the past related to this "typo"... There is
even a matching between DCC (for which the fix is now appied) and HTR
OrbitNumber in
http://cmslxr.fnal.gov/lxr/source/DQM/HcalMonitorTasks/src/HcalRawDataMonitor.cc?v=CMSSW_7_1_0_pre7#933
and I don't remember issuses...

Salavat

On Wed, 30 Apr 2014, Slava Krutelyov wrote:

+1

for #3562 d277df2
based on jenkins
the value doesn't seem to be used anywhere

@abdoulline Salavat, could you please comment if anything was actually
adversely affected in the past.


Reply to this email directly or view it
onGitHub.[5010650__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNDQ3MzM5MCwiZGF0YSI6eyJpZCI6MzEwMTU5N
jF9fQ==--f16452811aeda9e1d706a04dcac0da518a9093b8.gif]

@ktf ktf deleted the fix-wrong-operator branch June 4, 2014 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants