Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc bugs discovered by clang. #3572

Merged
merged 2 commits into from Apr 30, 2014
Merged

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Apr 29, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Fix misc bugs discovered by clang.

It involves the following packages:

CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos
Calibration/Tools

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor Author

ktf commented Apr 30, 2014

Bypassing AlCa. Complain if not ok.

ktf added a commit that referenced this pull request Apr 30, 2014
Clang -- Fix misc bugs discovered by clang.
@ktf ktf merged commit e8cb380 into cms-sw:CMSSW_7_1_X Apr 30, 2014
@ktf ktf deleted the fix-unused-variable branch April 30, 2014 09:49
@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Apr 30, 2014

faster than my +1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants