Disable looper track reconstruction for >= Run2_2016 #35721

mmusich · 2021-10-18T21:17:36Z

PR description:

It has been suggested that disabling the "looper" ¹ track reconstruction would save some reco computing time while not hindering any specific physics signal reconstruction.
A possible exception was identified with the B-Physics signals.
For this purpose a dedicated set of samples has been requested in this JIRA ticket PDMVRELVALS-128 to be studied by the BPH group.
The outcome of the study has been presented at the Tracking POG meeting of 18.08.2021.
Based on the conclusions that

"disabling loopers seems not to affect the topologies we are interested into. Some increase in the # of candidates is seen in line with expectations (@ lowp T & low eta). For some cases the performances are even better."

we proceed with the disabling for all eras >=Run2_2016, excluding the dedicated Heavy Ion ones.

PR validation:

Technically validated by running:

 runTheMatrix.py -l limited -j 4 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cc: @vmariani @AdrianoDee

trajectories of low-energy particles (either from PU or from the underlying event of the main scattering) which are spiralling in the magnetic field within the Tracker radius. For comparison pT=0.63 GeV is the maximum pT for a charged particle to loop within the 1.1m radius of the outermost Tracker barrel layer (with B=3.8T). ↩

cmsbuild · 2021-10-18T21:22:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35721/26042

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTracker/IterativeTracking/python/DetachedQuadStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/DetachedTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/HighPtTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/InitialStep_cff.py modified in PR(s): Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/LowPtBarrelTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385
- File RecoTracker/IterativeTracking/python/LowPtQuadStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/LowPtTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/MixedTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/PixelLessStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/PixelPairStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/TobTecStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686

cmsbuild · 2021-10-18T21:23:05Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/Eras (operations)
Configuration/ProcessModifiers (operations)
RecoTracker/IterativeTracking (reconstruction)

@perrotta, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Configuration/Eras/python/Era_Run3_cff.py

…rom all HI-related eras

cmsbuild · 2021-10-19T18:45:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35721/26074

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTracker/IterativeTracking/python/DetachedQuadStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/DetachedTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/HighPtTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/InitialStep_cff.py modified in PR(s): Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/LowPtBarrelTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385
- File RecoTracker/IterativeTracking/python/LowPtQuadStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/LowPtTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/MixedTripletStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/PixelLessStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/PixelPairStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686
- File RecoTracker/IterativeTracking/python/TobTecStep_cff.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385, Track DNN update on mkFit tracks #35686

cmsbuild · 2021-10-19T18:45:32Z

Pull request #35721 was updated. @perrotta, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

slava77 · 2021-10-19T19:53:42Z

Configuration/Eras/python/Era_Run2_2018_pp_on_AA_cff.py


-Run2_2018_pp_on_AA = cms.ModifierChain(Run2_2018.copyAndExclude([trackingMkFitProd]), pp_on_AA, pp_on_AA_2018)
+Run2_2018_pp_on_AA = cms.ModifierChain(Run2_2018.copyAndExclude([trackingMkFitProd, trackingNoLoopers]), pp_on_AA, pp_on_AA_2018)


@abaty @mandrenguyen
do you think looping track reconstruction is needed in the HI events?
I'd guess that they are even more costly in central events for CPU than for pp.

slava77 · 2021-10-19T21:02:13Z

@cmsbuild please test

cmsbuild · 2021-10-20T01:25:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24b217/19752/summary.html
COMMIT: 97af9c9
CMSSW: CMSSW_12_1_X_2021-10-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35721/19752/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 17204 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2751113
DQMHistoTests: Total failures: 65750
DQMHistoTests: Total nulls: 14
DQMHistoTests: Total successes: 2685327
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.02 KiB( 39 files compared)
DQMHistoSizes: changed ( 136.731 ): 0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.793 ): 0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.874 ): -0.004 KiB JetMET/SUSYDQM
Checked 170 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

slava77 · 2021-10-20T19:54:53Z

Reco comparison results: 17204 differences found in the comparisons

As expected, changes show up starting from Run2 pp workflows, with differences starting from tracking distributions at low pt central eta region, propagating downstream

There is a small increase in the number of PF charged low-pt candidates in the central region
e.g. 2018C EGamma wf 136.874

The distributions for 2016 data look somewhat similar.

in 2026 D76 PU(35?) wf 34834.999
there is some visible addition of tracks with hits with MTD

The changes seem fairly roughly consistent with the primary validation done in Run3 MC

slava77 · 2021-10-20T20:03:23Z

+reconstruction

for #35721 97af9c9

code changes are in line with the PR description and the follow up review
- possible extension to the HI reco is going to be followed up in review and possibly disable looper reconstruction for HeavyIons pp_on_* #35758
jenkins tests pass and comparisons with the baseline show differences starting from Run2 workflows as noted in Disable looper track reconstruction for >= Run2_2016 #35721 (comment) as well as in the PR description

@perrotta @qliphy
please consider this for pre5 as well.
Thank you.

slava77 · 2021-10-20T20:04:21Z

@perrotta @qliphy
please consider this for pre5 as well.

I checked in a local cmsrel that merges of #35721 and #35686 commute. (no conflict)

qliphy · 2021-10-21T00:45:51Z

+1

cmsbuild · 2021-10-21T00:46:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

create trackingNoLoopers modifier and use it

4f8c915

cmsbuild added this to the CMSSW_12_1_X milestone Oct 18, 2021

cmsbuild added code-checks-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 18, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 18, 2021

slava77 reviewed Oct 18, 2021

View reviewed changes

Configuration/Eras/python/Era_Run3_cff.py Outdated Show resolved Hide resolved

apply the noLoopers processModifier to Run2 2016 era and exclude it f…

97af9c9

…rom all HI-related eras

cmsbuild mentioned this pull request Oct 19, 2021

Track DNN update on mkFit tracks #35686

Merged

mmusich force-pushed the noLoopers branch from 44ec869 to 97af9c9 Compare October 19, 2021 18:38

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 19, 2021

mmusich changed the title ~~[RFC] Disable looper track reconstruction for Run3~~ [RFC] Disable looper track reconstruction for >= Run2_2016 Oct 19, 2021

mmusich changed the title ~~[RFC] Disable looper track reconstruction for >= Run2_2016~~ Disable looper track reconstruction for >= Run2_2016 Oct 19, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 19, 2021

slava77 reviewed Oct 19, 2021

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Oct 19, 2021

cmsbuild removed the tests-started label Oct 20, 2021

cmsbuild added the tests-approved label Oct 20, 2021

slava77 mentioned this pull request Oct 20, 2021

review and possibly disable looper reconstruction for HeavyIons pp_on_* #35758

Closed

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 20, 2021

cmsbuild removed the operations-pending label Oct 21, 2021

cmsbuild added fully-signed operations-approved orp-approved and removed pending-signatures orp-pending labels Oct 21, 2021

cmsbuild merged commit 3f8e286 into cms-sw:master Oct 21, 2021

mmusich mentioned this pull request May 11, 2022

Disabled looper reconstruction in HI Era for Run 3 #37833

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable looper track reconstruction for >= Run2_2016 #35721

Disable looper track reconstruction for >= Run2_2016 #35721

mmusich commented Oct 18, 2021 •

edited

cmsbuild commented Oct 18, 2021

cmsbuild commented Oct 18, 2021

cmsbuild commented Oct 19, 2021

cmsbuild commented Oct 19, 2021

slava77 Oct 19, 2021

slava77 commented Oct 19, 2021

cmsbuild commented Oct 20, 2021

slava77 commented Oct 20, 2021

slava77 commented Oct 20, 2021

slava77 commented Oct 20, 2021

qliphy commented Oct 21, 2021

cmsbuild commented Oct 21, 2021


		Run2_2018_pp_on_AA = cms.ModifierChain(Run2_2018.copyAndExclude([trackingMkFitProd]), pp_on_AA, pp_on_AA_2018)
		Run2_2018_pp_on_AA = cms.ModifierChain(Run2_2018.copyAndExclude([trackingMkFitProd, trackingNoLoopers]), pp_on_AA, pp_on_AA_2018)

Navigation Menu

Disable looper track reconstruction for >= Run2_2016 #35721

Disable looper track reconstruction for >= Run2_2016 #35721

Conversation

mmusich commented Oct 18, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Footnotes

cmsbuild commented Oct 18, 2021

cmsbuild commented Oct 18, 2021

cmsbuild commented Oct 19, 2021

cmsbuild commented Oct 19, 2021

slava77 Oct 19, 2021

Choose a reason for hiding this comment

slava77 commented Oct 19, 2021

cmsbuild commented Oct 20, 2021

Comparison Summary

slava77 commented Oct 20, 2021

slava77 commented Oct 20, 2021

slava77 commented Oct 20, 2021

qliphy commented Oct 21, 2021

cmsbuild commented Oct 21, 2021

mmusich commented Oct 18, 2021 •

edited