New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix for CLUE in BH section of HGCAL #35727
Conversation
Possibly for historical reasons dating back to the original implementation of the _imaging_ algorithm, from which CLUE has been derived, the critical distance in the BH section is treated differently. There is not _physics driven motivation_ for this behaviour. This set the critical distance parameter identical all over the Silicon detectors of HGCAL. The effect is visible in a much better separation of sibling showers in the BH section.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35727/26052
|
A new Pull Request was created by @rovere (Marco Rovere) for master. It involves the following packages:
@jpata, @AdrianoDee, @srimanob, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
assign hgcal-dpg |
@cmsbuild please test |
New categories assigned: hgcal-dpg @felicepantaleo,@rovere,@pfs,@cseez you have been requested to review this Pull request/Issue and eventually sign? Thanks |
type bug-fix |
@rovere |
@slava77 What I could offer is a comparison of the fake rate for the layer clusters (vs layer number) computed on the special sample I mentioned above:
|
@cmsbuild please test it seems like the last attempt got stuck. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c094c1/19755/summary.html Comparison SummarySummary:
|
+1 |
+reconstruction
|
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Possibly for historical reasons dating back to the original
implementation of the imaging algorithm, from which CLUE has been
derived, the critical distance in the BH section is treated differently.
There is no physics driven motivation for this behaviour. This sets
the critical distance parameter equal all over the Silicon detectors
of HGCAL. The effect is visible in a much better separation of sibling
showers in the BH section.
PR validation:
Validated on a privately produced sample of two
CloseBy
photons inBH
separated by3.5cm
to test merging vs separation.Before the fix
After the fix