Fix append bug in DQMEventMessage #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code obviously thought ‘std::string subFolderName = “Subfolder “ + idx;’ was appending ‘idx’ to the string. That is not what was happening. Instead, pointer math was happening. So if ‘idx’ was 1 the resulting string was “ubfolder “. If ‘idx’ was 2 we got ‘bfolder ‘. If ‘idx’ was larger than the string length we would get random garbage. This problem was found by clang.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Fix append bug in DQMEventMessage It involves the following packages: IOPool/Streamer @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
nclopezo
added a commit
that referenced
this pull request
Apr 30, 2014
IOPool/Streamer -- Fix append bug in DQMEventMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code obviously thought ‘std::string subFolderName = “Subfolder “ + idx;’ was appending ‘idx’ to the string. That is not what was happening. Instead, pointer math was happening. So if ‘idx’ was 1 the resulting string was “ubfolder “. If ‘idx’ was 2 we got ‘bfolder ‘. If ‘idx’ was larger than the string length we would get random garbage.
This problem was found by clang.