New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2 L1T DQM #35744
Phase2 L1T DQM #35744
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35744/26088
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35744/26089 |
A new Pull Request was created by @drankincms for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35744/26091 |
Pull request #35744 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please check and sign again. |
@drankincms in order to keep track of the L1T DQM developers, could you please also add yourself along with your github username in the comments to the corresponding e-group in here: |
} else if (fabs(mc_.eta) < 2.5) { | ||
h_L1Puppi_jet_ptratio_vs_pt_endcap_->Fill(mc_.pt, recopair.second.pt / mc_.pt); | ||
} else if (fabs(mc_.eta) < 3.) { | ||
h_L1Puppi_jet_ptratio_vs_pt_ecnotk_->Fill(mc_.pt, recopair.second.pt / mc_.pt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. Shouldn't it be something like _ecnohf_
instead of _ecnohf_
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
understood, these are b/w 2.5 and 3.0. OK
good to go. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS Comparison SummarySummary:
|
Perhaps I'm missing something but this doesn't look like an issue from this PR. Maybe someone else can take a look and confirm/deny |
This is a known issue #35868 and not related to this PR. |
merge |
@drankincms ----- Begin Fatal Exception 01-Nov-2021 04:07:22 CET----------------------- Would you please have a check? |
@qliphy I just tried this runTheMatrix workflow [1] and it seems to run fine in a fresh IB area. Is there another way I should be trying to debug? [1] |
@drankincms The issue persists in the new IB: CMSSW_12_2_X_2021-11-01-1100 Note IB runs with multi-thread, but PR test runs with single thread. I can reproduce the error with below: With single thread, it runs well: |
@drankincms It seems after including #35941 it works well with |
PR description:
Adding the first version of Phase 2 L1T DQM sequence. Adds plots for PF and PUPPI jets and particles as well track-specific validation.
PR validation:
Tested with runTheMatrix 23234.0, 100 events. All plots filled.
@rekovic @cbotta