Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 L1T DQM #35744

Merged
merged 7 commits into from Oct 31, 2021
Merged

Phase2 L1T DQM #35744

merged 7 commits into from Oct 31, 2021

Conversation

drankincms
Copy link
Contributor

PR description:

Adding the first version of Phase 2 L1T DQM sequence. Adds plots for PF and PUPPI jets and particles as well track-specific validation.

PR validation:

Tested with runTheMatrix 23234.0, 100 events. All plots filled.

@rekovic @cbotta

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35744/26088

  • This PR adds an extra 40KB to repository

  • Found files with invalid states:

    • DQMOffline/L1Trigger/src/L1TPhase2OTTrackJetsandMHT.cc:
    • DQMOffline/L1Trigger/interface/L1TPhase2OTTrackJetsandMHT.h:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35744/26089

  • This PR adds an extra 44KB to repository

  • Found files with invalid states:

    • DQMOffline/L1Trigger/src/L1TPhase2OTTrackJetsandMHT.cc:
    • DQMOffline/L1Trigger/interface/L1TPhase2OTTrackJetsandMHT.h:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @drankincms for master.

It involves the following packages:

  • DQMOffline/Configuration (dqm)
  • DQMOffline/L1Trigger (dqm, l1)

@emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35744/26091

  • This PR adds an extra 44KB to repository

  • Found files with invalid states:

    • DQMOffline/L1Trigger/src/L1TPhase2OTTrackJetsandMHT.cc:
    • DQMOffline/L1Trigger/interface/L1TPhase2OTTrackJetsandMHT.h:

@cmsbuild
Copy link
Contributor

Pull request #35744 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please check and sign again.

@jfernan2
Copy link
Contributor

@drankincms in order to keep track of the L1T DQM developers, could you please also add yourself along with your github username in the comments to the corresponding e-group in here:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#L1T
?
Thanks

} else if (fabs(mc_.eta) < 2.5) {
h_L1Puppi_jet_ptratio_vs_pt_endcap_->Fill(mc_.pt, recopair.second.pt / mc_.pt);
} else if (fabs(mc_.eta) < 3.) {
h_L1Puppi_jet_ptratio_vs_pt_ecnotk_->Fill(mc_.pt, recopair.second.pt / mc_.pt);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. Shouldn't it be something like _ecnohf_ instead of _ecnohf_ ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understood, these are b/w 2.5 and 3.0. OK

@rekovic
Copy link
Contributor

rekovic commented Oct 27, 2021

good to go.

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 30, 2021

please test
just to test again to make sure it works, as last test was done 5 days ago.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d14bb2/20102/summary.html
COMMIT: c15e0e6
CMSSW: CMSSW_12_2_X_2021-10-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35744/20102/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901405
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1705.235 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 341.047 KiB L1T/L1TPhase2
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@drankincms
Copy link
Contributor Author

Perhaps I'm missing something but this doesn't look like an issue from this PR. Maybe someone else can take a look and confirm/deny

@qliphy
Copy link
Contributor

qliphy commented Oct 31, 2021

Perhaps I'm missing something but this doesn't look like an issue from this PR. Maybe someone else can take a look and confirm/deny

This is a known issue #35868 and not related to this PR.

@qliphy
Copy link
Contributor

qliphy commented Oct 31, 2021

merge

@qliphy
Copy link
Contributor

qliphy commented Nov 1, 2021

@drankincms
This PR seems to cause a IB issue
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_2_X_2021-10-31-2300/pyRelValMatrixLogs/run/23234.103_TTbar_14TeV+2026D49Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_TTbar_14TeV+2026D49Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log#/489-489

----- Begin Fatal Exception 01-Nov-2021 04:07:22 CET-----------------------
An exception of category 'FatalRootError' occurred while
[0] Processing global end Run run: 1
[1] Calling method for module L1TPhase2CorrelatorOffline/'l1tPhase2CorrelatorOfflineDQM'
Additional Info:
[a] Fatal Root Error: @sub=TH1D::ComputeIntegral
Integral = zero

Would you please have a check?
adding @cms-sw/dqm-l2 @cms-sw/l1-l2

@drankincms
Copy link
Contributor Author

@qliphy I just tried this runTheMatrix workflow [1] and it seems to run fine in a fresh IB area. Is there another way I should be trying to debug?

[1] runTheMatrix.py -l 23234.103 --command -n 5

@qliphy
Copy link
Contributor

qliphy commented Nov 2, 2021

@drankincms The issue persists in the new IB: CMSSW_12_2_X_2021-11-01-1100

Note IB runs with multi-thread, but PR test runs with single thread.

I can reproduce the error with below:
runTheMatrix.py -l 23234.103 --job-reports -t -4 --ibeos

With single thread, it runs well:
runTheMatrix.py -l 23234.103 --job-reports --ibeos

@qliphy
Copy link
Contributor

qliphy commented Nov 2, 2021

@drankincms It seems after including #35941 it works well with
runTheMatrix.py -l 23234.103 --job-reports -t -4 --ibeos
Let's wait the IB test results after merging #35941

@perrotta
Copy link
Contributor

perrotta commented Nov 3, 2021

The same issue notified above is also present in CMSSW_12_2_X_2021-11-03-1100, which includes #35941
It is the same workflow 23234.103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants