Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ALCARECOTkAlCosmicsCosmicTF0T track collection in Millepede code [12.0.X] #35745

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 20, 2021

backport of #35694

PR description:

Adding new collection of cosmics ALCARECOTkAlCosmicsCosmicTF0T in commonValidation

PR validation:

Private

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #35694

@antoniovagnerini FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

  • Alignment/CommonAlignment (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 20, 2021

please test

@antoniovagnerini
Copy link
Contributor

thank you for the backport!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e0728/19766/summary.html
COMMIT: 7065268
CMSSW: CMSSW_12_0_X_2021-10-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35745/19766/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Oct 20, 2021

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 21, 2021

+1

@cmsbuild cmsbuild merged commit 137b3bb into cms-sw:CMSSW_12_0_X Oct 21, 2021
@mmusich mmusich deleted the addALCARECOTkAlCosmicsCosmicTF0T_12_0_X branch October 21, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants