New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing of binning of GEM digi plots on GEM onlineDQM, backport to CMSSW_12_0_X #35746
Changing of binning of GEM digi plots on GEM onlineDQM, backport to CMSSW_12_0_X #35746
Conversation
A new Pull Request was created by @quark2 for CMSSW_12_0_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport of #35733 |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da248e/19794/summary.html Comparison SummarySummary:
|
Hi @quark2 |
Hi @jfernan2, I think the plots in GEM sides under the changes look okay as desired. But there are so many blacklisted plots in overall onlineDQM plots. Especially, some plots in "Info" part are not visible by the issue. It seems not due to my PR, though. Could you check it? Thanks, |
Thanks @quark2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
A binning of some plots is changed; the range of indices of GEM digis is 0-383 currently, while the binning in the previous version covers 1-384, related to #35733.
Also, some namings have been changed, which is related to #35690.
PR validation:
Test are done and one can check again by
runTheMatrix
workflowsif this PR is a backport please specify the original PR and why you need to backport that PR:
This is a backport of #35690 and #35733 to CMSSW_12_0_X to be deployed on the upcoming runs
@jshlee @watson-ij