Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing of binning of GEM digi plots on GEM onlineDQM, backport to CMSSW_12_0_X #35746

Merged

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Oct 20, 2021

PR description:

A binning of some plots is changed; the range of indices of GEM digis is 0-383 currently, while the binning in the previous version covers 1-384, related to #35733.

Also, some namings have been changed, which is related to #35690.

PR validation:

Test are done and one can check again by runTheMatrix workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #35690 and #35733 to CMSSW_12_0_X to be deployed on the upcoming runs

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2021

A new Pull Request was created by @quark2 for CMSSW_12_0_X.

It involves the following packages:

  • DQM/GEM (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #35733

@jfernan2
Copy link
Contributor

test parameters:

  • addpkg = DQM/Integration

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da248e/19794/summary.html
COMMIT: 5cf0ebf
CMSSW: CMSSW_12_0_X_2021-10-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35746/19794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

Hi @quark2
Could you please check in DQM GUI playback that the changes for this PR and dmwm/deployment#1096 are as you expect?

https://cmsweb.cern.ch/dqm/online-playback/
Thanks

@quark2
Copy link
Contributor Author

quark2 commented Oct 21, 2021

Hi @jfernan2,

I think the plots in GEM sides under the changes look okay as desired. But there are so many blacklisted plots in overall onlineDQM plots. Especially, some plots in "Info" part are not visible by the issue. It seems not due to my PR, though. Could you check it?

Thanks,
Byeonghak Ko

@jfernan2
Copy link
Contributor

Thanks @quark2
Yeah indeed the blacklisting is not due to this PR
I am signing this and asking for integration of the deployment one

@jfernan2
Copy link
Contributor

+1
Tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 23, 2021

+1

@cmsbuild cmsbuild merged commit 506e9a7 into cms-sw:CMSSW_12_0_X Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants