modernize DQM/TrackerCommon [12.0.X]

[mmusich]

backport of #35782

PR description:

It was noticed in the CMSHLT-2188 that the filter DetectorStateFilter is not working in Run3 data, likely because the DCS information from SCAL is not available. I provide here a fix to take instead the information from DCSRecord provided by the OnlineMetaDataDigis collection.
I profit to add fillDescriptions methods and also to include header files in the same file as the plugin implementation.

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #35782

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

• DQM/TrackerCommon (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from modernize DQM/TrackerCommon #35782

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c5d8f/19838/summary.html
COMMIT: b0cbc1f
CMSSW: CMSSW_12_0_X_2021-10-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35783/19838/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998542
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

urgent

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[jfernan2]

@mmusich I have signed without testing in Online DQM at P5 since I understand it is urgent and it does not affect Online DQM, but please correct me if I am wrong
Thanks

[mmusich]

@jfernan2 for a quirk of naming, this module is apparently used nowhere in offline (https://cmssdt.cern.ch/dxr/CMSSW/search?q=detectorStateFilter) , but only at HLT.
I would safely assume it's not used in online DQM as wel.

[jfernan2]

Well, as long as it is used in HLT, it may be used in Offline, right?
https://github.com/cms-sw/cmssw/search?q=HLT_GRun_cff
Thanks

[mmusich]

I meant in Tier0/offline DQM.
It is tested in integration tests via the addOn tests (but not the full functionality as there's not yet a real Run3 menu)

[mmusich]

@perrotta @qliphy please clarify the integration plans for this PR.
I have further simplifications at #35808 that might be backported here too.

[perrotta]

+1

• merged in the master IBs since CMSSW_12_1_X_2021-10-23-1100