Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made static a member data in DeterministicAnnealing #3579

Conversation

Dr15Jones
Copy link
Contributor

A static was being used to store state information for the class
DeterministicAnnealing. This was moved to a member variable in
order to avoid thread-safety problems.

A static was being used to store state information for the class
DeterministicAnnealing. This was moved to a member variable in
order to avoid thread-safety problems.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made static a member data in DeterministicAnnealing

It involves the following packages:

RecoVertex/VertexTools

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 1, 2014

+1

for #3579 0ec184e
tested OK in
CMSSW_7_1_X_2014-04-30-0200 /test area sign363

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request May 1, 2014
…Annealing

Made static a member data in DeterministicAnnealing
@davidlange6 davidlange6 merged commit 23ea0ba into cms-sw:CMSSW_7_1_X May 1, 2014
@Dr15Jones Dr15Jones deleted the removeStaticFromDeterministicAnnealing branch May 6, 2014 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants