Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker Alignment] Python3 migration fixes for 12.0.X #35791

Merged
merged 1 commit into from Oct 24, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 22, 2021

backport of #35788

PR description:

Set of changes to ensure the smooth running of the MP alignment and the All-In-One tool for the validation of the alignment conditions

  • Fix subprocess.check_output() requiring decode()
  • Add deep copy of submitted_jobs to avoid problems while iterating
  • Cast .oO[nEvents]Oo. / .oO[parallelJobs]Oo. as int
  • list() method

PR validation:

Private

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a verbatim backport of #35788

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)
  • Alignment/OfflineValidation (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 22, 2021

@cms-sw/alca-l2 please consider this for CMSSW_12_0_4

@mmusich
Copy link
Contributor Author

mmusich commented Oct 22, 2021

please test

@tvami
Copy link
Contributor

tvami commented Oct 22, 2021

urgent

@tvami
Copy link
Contributor

tvami commented Oct 22, 2021

@cms-sw/alca-l2 please consider this for CMSSW_12_0_4

Hi @perrotta @qliphy AlCa supports this, although the PR in not directly needed for online data taking, it is needed to produce the alignment calibrations (used in data taking)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3a7b0/19851/summary.html
COMMIT: 547384a
CMSSW: CMSSW_12_0_X_2021-10-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35791/19851/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Oct 23, 2021

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 24, 2021

+1

@cmsbuild cmsbuild merged commit 58562b9 into cms-sw:CMSSW_12_0_X Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants