GEMGeometryBuilder bugfix

[jshlee]

PR description:

• stopping non-existing chambers to be added to superchambers
• no changes are expected

PR validation:

tested with wf 34611.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35855/26231

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @jshlee (Jason Lee) for master.

It involves the following packages:

• Geometry/GEMGeometryBuilder (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@dildick, @bsunanda, @slomeo, @fabiocos, @watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

type bug-fix

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b42cd8/19967/summary.html
COMMIT: 7d4f2a7
CMSSW: CMSSW_12_1_X_2021-10-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35855/19967/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 2797338
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2797310
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 173 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[civanch]

@jshlee , can you, please, explain what is the change for Run-3 GEM geometry? Or this is only for Phase-2?

[jshlee]

@jshlee , can you, please, explain what is the change for Run-3 GEM geometry? Or this is only for Phase-2?

@civanch, this is to protect invalid pointers being added to the geometry. This doesn't change the geometry.

[civanch]

+1

[srimanob]

Hi @jshlee
I am confused a bit on the PR description and code changes. It seems the original code already protect non-exisitng chamber already. This PR seems to add existing chamber to super chamber. What will happen if you don't add chamber to superChamber (i.e. now)?

[jshlee]

the original code would just send the logwarning if the chamber is invalid and still add it to the superchamber.

[srimanob]

Ah, OK. I miss line 528 of the original code. Thanks.

[srimanob]

type bug-fix

[srimanob]

+Upgrade

This is a bug-fix PR, to include only existing GEM chamber to super chamber.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1