New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making beamspot DIP server more verbose and additional fixes [12_0_X] #35860
Making beamspot DIP server more verbose and additional fixes [12_0_X] #35860
Conversation
A new Pull Request was created by @sikler (Ferenc Siklr) for CMSSW_12_0_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Pull request #35860 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f96a1/20203/summary.html Comparison SummarySummary:
|
@sikler we tested this PR in Online DQM playback at P5 and runs ok. |
@jfernan2 Please give me some days (I want to test some functionality with help of the local CMS DIP browser https://cmsonline.cern.ch/webcenter/portal/cmsonline/pages_common/dcs/dipbrowser). Well, that thing exists, would have been extra good for the pilot run. |
Pull request #35860 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
Pull request #35860 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
Pull request #35860 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
@sikler sorry for not following up earlier: what is the status of this PR? |
@francescobrivio It was tested, worked well, ready to go. |
That's great thanks! @jfernan2 @ahmad3213 @pmandrik I think we need another playback with this before merging right? |
@cmsbuild please test |
Hi, we did not remove it since previous green-light for production, so, at the moment the PR is already merged into production. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f96a1/20571/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@jfernan2 I am doing the forwardport right now. |
backport of #36152 |
thanks @sikler! |
+1
|
PR description:
Adding MessageLogger, LogInfo output and setting 'verbose' flag.
Replaced DIM/DIP DNS to local CMS: cmsdimns1.cern.ch.
Fixed sending messages.
PR validation at P5:
Works well, tested with fake data on 8 Nov, details and screen shots
https://twiki.cern.ch/twiki/bin/view/CMS/OnlineBeamSpotRun3#8_Nov_2021_new_information_on_lo