Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making beamspot DIP server more verbose and additional fixes [12_0_X] #35860

Merged
merged 6 commits into from Nov 17, 2021

Conversation

sikler
Copy link
Contributor

@sikler sikler commented Oct 27, 2021

PR description:

Adding MessageLogger, LogInfo output and setting 'verbose' flag.
Replaced DIM/DIP DNS to local CMS: cmsdimns1.cern.ch.
Fixed sending messages.

PR validation at P5:

Works well, tested with fake data on 8 Nov, details and screen shots
https://twiki.cern.ch/twiki/bin/view/CMS/OnlineBeamSpotRun3#8_Nov_2021_new_information_on_lo

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Oct 27, 2021
@sikler sikler changed the title Beamspotdipserver verbose Making beamspot DIP server more verbose Oct 27, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2021

A new Pull Request was created by @sikler (Ferenc Siklr) for CMSSW_12_0_X.

It involves the following packages:

  • DQM/BeamMonitor (dqm)
  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@sikler sikler changed the title Making beamspot DIP server more verbose Making beamspot DIP server more verbose [12_0_X] Oct 27, 2021
@cmsbuild
Copy link
Contributor

Pull request #35860 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f96a1/20203/summary.html
COMMIT: cd3fd2d
CMSSW: CMSSW_12_0_X_2021-11-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35860/20203/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 4, 2021

@sikler we tested this PR in Online DQM playback at P5 and runs ok.
I am not sure if you expect to add more changes. We may need a forwardport to master at some point

@sikler
Copy link
Contributor Author

sikler commented Nov 5, 2021

@jfernan2 Please give me some days (I want to test some functionality with help of the local CMS DIP browser https://cmsonline.cern.ch/webcenter/portal/cmsonline/pages_common/dcs/dipbrowser). Well, that thing exists, would have been extra good for the pilot run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

Pull request #35860 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

Pull request #35860 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

Pull request #35860 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@sikler sikler marked this pull request as ready for review November 8, 2021 12:15
@sikler sikler changed the title Making beamspot DIP server more verbose [12_0_X] Making beamspot DIP server more verbose and additional fixes [12_0_X] Nov 8, 2021
@francescobrivio
Copy link
Contributor

@sikler sorry for not following up earlier: what is the status of this PR?

@sikler
Copy link
Contributor Author

sikler commented Nov 16, 2021

@francescobrivio
Copy link
Contributor

francescobrivio commented Nov 16, 2021

That's great thanks!
BTW, is there already a forwarport of this to 12_2_X @sikler ?

@jfernan2 @ahmad3213 @pmandrik I think we need another playback with this before merging right?

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@pmandrik
Copy link
Contributor

That's great thanks! BTW, is there already a forwarport of this to 12_2_X @sikler ?

@jfernan2 @ahmad3213 @pmandrik I think we need another playback with this before merging right?

Hi, we did not remove it since previous green-light for production, so, at the moment the PR is already merged into production.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f96a1/20571/summary.html
COMMIT: 2baf040
CMSSW: CMSSW_12_0_X_2021-11-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35860/20571/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
Forwardport to master needed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@sikler
Copy link
Contributor Author

sikler commented Nov 17, 2021

@jfernan2 I am doing the forwardport right now.

@sikler
Copy link
Contributor Author

sikler commented Nov 17, 2021

#36152

@francescobrivio
Copy link
Contributor

backport of #36152

@francescobrivio
Copy link
Contributor

thanks @sikler!

@perrotta
Copy link
Contributor

+1

  • This is fully signed, and actually fully tested at P5 (even better: "already merged into production")
  • There is no need to wait for the results of the IB tests in the master to merge, then

@cmsbuild cmsbuild merged commit 1d97841 into cms-sw:CMSSW_12_0_X Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants