HLT menu development

[Martin-Grunewald]

PR description:

HLT menu development
Based on CMSSW_12_1_X_2021-10-26-2300

• Update of Scouting Path (CMSHLT-2150)
• PPS calibration paths (CMSHLT-2179)
• EGM HLT: noise cleaned cluster shape variable (CMSHLT-2180)

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35863/26249

• This PR adds an extra 824KB to repository

[cmsbuild]

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6856d7/19987/summary.html
COMMIT: 094ee9c
CMSSW: CMSSW_12_1_X_2021-10-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35863/19987/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-6856d7/11634.914_TTbar_14TeV+2021_DDDDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-6856d7/38634.0_TTbar_14TeV+2026D86+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901437
• DQMHistoTests: Total failures: 401
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901013
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.081 KiB( 41 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 0.017 KiB HLT/Filters
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: found differences in 5 / 41 workflows

[missirol]

Small-but-visible changes in some EGM triggers.
Efficiency<100% for Scouting path (now using stricter selection on L1T seed).
In general, looks in agreement with expectations.

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• HLT menu development

[perrotta]

@Martin-Grunewald @missirol
There is now a unit test failure in the IB for RecoTauTag/HLTProducers, which apparently originates from HLTScoutingPFProducer. Since you update here the scouting path, could you please have a quick look at it? We are going to close with 12_1_0_pre5, and if there are no fixes we will have to revert the merging of this PR

[missirol]

Looking into it. If a solution is not identified quickly, would it be better to make a PR to disable the unit test (instead of reverting this PR)?

[Martin-Grunewald]

For me, the unit test in question, https://github.com/cms-sw/cmssw/blob/master/RecoTauTag/HLTProducers/test/testL2TauTagNN.py seems unacceptable as a unit test as it appears to run the menu itself in a special environment, customised, which now fails as the input menu has changed. This goes way beyond a supposedly simple unit test. So the required course of action is to remove the unit test.

[missirol]

Okay, I will make a PR to remove the unit test (while trying to figure out if there is any kind of underlying problem).