Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkDQM: PixelPhase1 Summary plots #35865

Merged
merged 12 commits into from Nov 4, 2021
Merged

TkDQM: PixelPhase1 Summary plots #35865

merged 12 commits into from Nov 4, 2021

Conversation

sayanchatterjee38
Copy link
Contributor

Title:

TkDQM: PixelPhase1 Summary plots

PR description:

The aim of this PR is to Implement a 3 state (GOOD, WARNING, ERROR) Summary Maps for PixelPhase1 in ONLINE DQM. Pixel online client tested locally over RAW data.

Links of the last presentation in TkDQM bi-weekly meeting:

https://indico.cern.ch/event/1000820/#b-407796-tracker-dqm

PR validation:

Checks are done with workflow 136.892 and no changes are observed.

If this PR is a backport please specify the original PR and why you need to backport that PR:

NA

@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Oct 27, 2021
@sayanchatterjee38 sayanchatterjee38 changed the title Sayan&nihar_SiPixelPhase1Summary_CMSSW_12_1_X_2021_10_26_1100 TkDQM: PixelPhase1 Summary plots Oct 27, 2021
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35865/26253

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35865/26255

ERROR: Build errors found during clang-tidy run.

DQM/SiPixelPhase1Summary/src/SiPixelPhase1Summary.cc:286:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
DQM/SiPixelPhase1Summary/src/SiPixelPhase1Summary.cc:336:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Suppressed 1777 warnings (1776 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35865/26256

ERROR: Build errors found during clang-tidy run.

DQM/SiPixelPhase1Summary/src/SiPixelPhase1Summary.cc:286:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
DQM/SiPixelPhase1Summary/src/SiPixelPhase1Summary.cc:336:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Suppressed 1777 warnings (1776 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35865/26409

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

Pull request #35865 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@sroychow
Copy link
Contributor

sroychow commented Nov 4, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60ad63/20242/summary.html
COMMIT: 65d409f
CMSSW: CMSSW_12_2_X_2021-11-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35865/20242/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2901843
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 4, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 4, 2021

+1

@cmsbuild cmsbuild merged commit 3ca4fa6 into cms-sw:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants