Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add process.runType.commissioning_run in the supported types of beampixel_dqm_sourceclient-live (backport) #35870

Merged
merged 1 commit into from Oct 30, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 28, 2021

backport of #35869

PR description:

To fix a crash observed in the test beam when a run of DQM type commissioning_run was taken (see log)

PR validation:

None

if this PR is a backport please specify the original PR and why you need to backport that PR:

Should be backported.

@mmusich mmusich changed the title add process.runType.commissioning_run in the supported types of beampixel_dqm_sourceclient-live add process.runType.commissioning_run in the supported types of beampixel_dqm_sourceclient-live (backport) Oct 28, 2021
@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Oct 28, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 28, 2021

type bug-fix

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@francescobrivio
Copy link
Contributor

@jfernan2 @ahmad3213 @pmandrik this should fix the issue reported this morning.
To be tested in playback on a run which has run type commissioning_run (e.g. 346314)

@francescobrivio
Copy link
Contributor

FYI @dinardo

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd6a78/20003/summary.html
COMMIT: 43a0acc
CMSSW: CMSSW_12_0_X_2021-10-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35870/20003/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
Tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 30, 2021

+1

@cmsbuild cmsbuild merged commit f12354b into cms-sw:CMSSW_12_0_X Oct 30, 2021
@mmusich mmusich deleted the fix_beam_pixel_client_12_0_X branch October 30, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants