Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix era for DQM BeamSpot clients [12_0_X] #35899

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Oct 29, 2021

PR description:

Backport of #35898
Fix the era modifier for the DQM BeamSpot clients.

PR validation:

Should be tested in Playback at P5.

Backport

Backport of #35898

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2021

A new Pull Request was created by @francescobrivio for CMSSW_12_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #35898

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

@jfernan2 @ahmad3213 @pmandrik this is another one to be tested in playback, run 346373 should be fine here too.
Thanks and sorry for the many PRs!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2befb/20053/summary.html
COMMIT: d001670
CMSSW: CMSSW_12_0_X_2021-10-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35899/20053/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 29, 2021

+1
Tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Oct 29, 2021

@qliphy @perrotta also this one is tested in DQM playback system and should be merged asap so DQM team (@ahmad3213 and @pmandrik) can deploy it in production before the SB tonight.

The validation of this PR comes from the playback DQM plot:
Schermata 2021-10-29 alle 18 25 14

which shows the transverse width of the BeamSpot is correctly computed by the Legacy BeamSpot client.
Opposite to the plot seen yesterday evening online:

Schermata 2021-10-29 alle 18 26 46

@francescobrivio
Copy link
Contributor Author

urgent

@qliphy
Copy link
Contributor

qliphy commented Oct 30, 2021

@francescobrivio Ok, we can merge it now. But notice usually we need the master PR to be merged first.

@qliphy
Copy link
Contributor

qliphy commented Oct 30, 2021

+1

@cmsbuild cmsbuild merged commit 1b8b01b into cms-sw:CMSSW_12_0_X Oct 30, 2021
@francescobrivio francescobrivio deleted the alca-BS_eraModifier_12_0_X branch November 3, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants